[CF-Devel] RE: [Crossfire-cvs] CVS commit: CFJavaEditor

[Andreas Vogl]

Referring to the following cvs commit by Bob Tanner:

>
     
      Module Name:	CFJavaEditor
     
     >
     
      Committed By:	tanner
     
     >
     
      Date:		Wed Jan  2 08:54:57 UTC 2002
     
     >
     
      [...]
     
     >
     
      Log Message:
     
     >
     
        General changes to most of the files list below:
     
     >
     
        Some simple changes to make building the editor under Linux a
     
     >
     
        little easier. Start of stylistic changes to be compliant
     
     >
     
        with doc/programming_guide. Pretty-printted most of the code.
     
     >
     
     
     >
     
      Conceptual changes:
     
     >
     
        Change the concept of where resources are located. Instead of
     
     >
     
        having resource files in specific directories I put them all in
     
     >
     
        the .jar file and extract them as needed. This change is complete
     
     >
     
        except for the images in the system directory. [...]
     
     
First of all, I'm grateful for the work you have done to improve
the linux build configuration for CFJavaEditor.

However, as I took a look at the newest cvs version of
the editor today, I noticed unfortunately that there are some changes
which I don't like:

o The biggest Problem is the new formatting. The linux tabs turn out
  completely corrupt in Visual J++ (Windows).
  Please convert all tabs into spaces, if that is possible. That is
  the only way to keep the formatting platform-independant.
  
  Besides, I actually liked my old formatting with 4 space indent.
  And I believe MichToen did so too. But nevermind on that one...
  
o Why is the source code suddenly in
"/src/org/crossfire/editor/CFEditor"?
  Did you try to hide it or something?
  This new directory strucure might be handy in *your* editor, it
  definitly is not in mine. Besides, to my knowing it is convention
  that Package name and directory path are identical. Visual J++
enforces
  this. The new Package name "org.crossfire.editor.CFEditor" therefore
  doesn't work. It has to be "src.org.crossfire.editor.CFEditor".
  However, I would greatly prefer the *.java files back in the
  "/CFEditor" dir, where they belong.

o The new policy of extracting all resources out of the .jar file
  doesn't seem like a good idea to me. Unless I totally misunderstood
  your purpose.
  Resource files (like icons and config files like "autojoin.txt")
  should be easy to access and easy to modify. If they are burried
  in the jar file, the average user won't find them.
  And you have no visual control over the stuff in the jar file
  either. If someone commits a corrupt jar file, will that be
  noticeable from the cvs diff? I guess not - though effectively all
  resource files are lost.


Well, I hope that doesn't sound too criticizing.
I'm sorry that I didn't come up with these issues earlier, but I
was busy and didn't have time to test the new stuff before.
Besides, I wasn't really aware of these changes and nobody asked me.


Andreas V.