[CF-Devel] Re: AW: [Crossfire-cvs] CVS commit: crossfire]

[crossfire-devel at archives.real-time.com]

>
     
       IMO, that is a broken fix.
     
     >
     
     
     >
     
       It should be expected that if you make a call to reset_object() that 
     
     >
     
      none of the fields have any meaningful value.  Thus, passing in data 
     
     >
     
      that has been malloc'd should be perfectly valid (I think there may be 
     
     >
     
      other areas of the code that do something similar, but not 100% sure).
     
     <snip>
Seems you fixed in CVS already, many thanks.

>
     
       Depends.  get_object() provides objects on teh global linked list.  
     
     >
     
      This is not always desirable - objects on the global list may get 
     
     >
     
      processed in various ways, which you don't want to have happen to things 
     
     >
     
      like the artifact objects. This is why I believe that it did in fact 
     
     >
     
      malloc the data instead of using get_object()
     
     
Hum ok. This just means the objects won't be reused, but since they are actual 
archetypes, shouldn't be an issue :)

Note that the difference between reset_object & clear_object is another reason i 
feel like adding comments... (first will accept any uninitialized item, second 
needs valid/null pointers)

Nicolas 'Ryo'


_______________________________________________
crossfire-devel mailing list
     
     crossfire-devel at lists.real-time.com
     
     
     https://mailman.real-time.com/mailman/listinfo/crossfire-devel