[CF-Devel] PATCH, fixing, ac/wc, overflow, after, holy, possession/bless/curse

Wed Mar 5 00:35:43 CST 2003

Jochen Suckfuell wrote:
>

      Hi!

     >

     >

      The following patch fixes an overflow that happened when the ac/wc bonus from

     >

      holy possession, bless or curse exceeded the signed byte limit.

     >

     >

      It's done by using short tmp values to check for an overflow, and then

     >

      limiting the bonus to 127/-128 .

  Is this actually a problem?  I looked at the code, and the current spell 
params - the spell the gains the most rapidly is 'holy possession' - if I read 
the code right, for every 4 levels, it should increase the damage by 1.

  Looking further, it appears the problem is that if you cast bless over and 
over, the effects stack.  IMO, I don't think that is really the intended 
behaviour - I think what is really intended is that if you have bless, you can 
re-cast it to reset the duration so that it doesn't expire as soon.  I'd 
personally think that the += values currently in place should just be replaced 
with = values.

  In any case, the patch as you submitted isn't acceptably anyway - it doesn't 
use standard C constructs - you are using // comments as well as declaring new 
variables in the middle of code blocks.  These would be easy points to fix if 
people think this is the desired fix.

_______________________________________________
crossfire-devel mailing list

     crossfire-devel at lists.real-time.com

     https://mailman.real-time.com/mailman/listinfo/crossfire-devel