[CF-Devel] cfclient 1.5.0 segmentation fault by window resizing

[crossfire-devel-admin at archives.real-time.com]

H. S. Teoh wrote:
>
     
      On Fri, May 16, 2003 at 12:22:07AM -0700, Mark Wedel wrote:
     
     >
     
     
     >>
     
     Claudio Fontana wrote:
     
     >>
     
     
     >>>
     
     Here are some details:
     
     >>
     
     
     >>
     
      Does it always crash when you resize the window?  Is this making the 
     
     >>
     
      window bigger/smaller (taller/wider?)  What about other options like 
     
     >>
     
     scrollback size and what not?
     
     >>
     
     
     >>
     
      Easier to fix these types of bugs if I can reproduce it locally - also 
     
     >>
     
      easier to verify that it is really fixed.
     
     >
     
     
     >
     
      [snip]
     
     >
     
     
     >
     
      This is unrelated, but since we're talking about cfclient bugs...  I've
     
     >
     
      consistently seen cfclient crash with Invalid GC X protocol errors. As an
     
     >
     
      ugly hack, I've added code to register an Xlib error handler so that
     
     >
     
      cfclient doesn't crash; but the result is that when these invalid GC's
     
     >
     
      start to happen, random images on the map or the inventory start to
     
     >
     
      vanish. 
     
     >
     
     
     >
     
      It seems that somewhere, cfclient is somehow forgetting that a GC has
     
     >
     
      already been deleted (or perhaps a GC number got corrupted?), and tries to
     
     >
     
      draw a tile with an invalid GC. One observation is that when this happens,
     
     >
     
      it consistently happens to the same png image (often one frame of an
     
     >
     
      animated tile) until the tile is out of sight, whereupon it will start
     
     >
     
      happening to another tile. Also, once it starts to happen, it never goes
     
     >
     
      away, but only gets worse (more tiles start getting corrupt GC values).
     
     >
     
     
     >
     
      Any clues on what's causing this? It's getting rather annoying since I
     
     >
     
      have to restart the client every once in a while so that I don't miss
     
     >
     
      objects that have become invisible because their image has a bad GC.
     
     
  The x11 client now in CVS should be usable with big images.

  There were numerous things that were broken.  Worse was a buffer overflow
when rendering the images (that code, included the ximage used, assumed images
would be 32x32).

  There were also other bugs related to not filling in proper head/tail 
information in the map structure, and the_map structure not really being big enough.

  There is still the problem of disappearing buildings, which I believe is a 
problem on the server code, but not 100% sure, so have to take a closer look.


_______________________________________________
crossfire-devel mailing list
     
     crossfire-devel at lists.real-time.com
     
     
     https://mailman.real-time.com/mailman/listinfo/crossfire-devel