[CF-Devel] Talisman bugs

[crossfire-devel at archives.real-time.com]

Nicolas Weeger wrote:
>
     
      Playing on crossfire.metalforge.net, there's a bug with talismans.
     
     >
     
     
     >
     
      I have a talisman of unified mind, but it's never used. Old skill system 
     
     >
     
      made it that player would automatically use a talisman when available, 
     
     >
     
      to boost magic (assuming player got the spell, of course, else talisman 
     
     >
     
      with that skill becomes required)
     
     >
     
     
     >
     
      So it seems talismans aren't used, and holy symbols aren't either...
     
     
  I've just fixed the code so that you can now manually apply talismans and 
other skill objects.  If applied, you then get whatever benefit they object 
provides when casting the spell.

  IT is intentional that the code uses innate/learned skills if available.  One 
can argue that this is more realistic (if you can just cast something, you're 
not going to fumble about for a talisman/holy symbol).  Some of this is code 
simplicity.  Some of this is that there is no good answer - if you have a 
talisman that grants you a skill, but has some negative aspects (repelled or 
denied spellpaths), the question then comes up of whether you really want that 
to be used instead of a skill which may have no negative side effects.  And in 
fact, I recall there were past complaints on auto apply talismans simply because 
of that (as a note, the order of a players inventory is effectively random, so 
you also get into problems of one time, talisman X might be used, but next time 
you play, talisman y).

  And I really don't want to go down the path of trying to find the right 
talisman for the spell.  The skill code isn't really designed for that (the 
finding the necessary skill right now is quite abstract - it is used for all 
skills - I don't want something of 'well, if a spell is being cast, then the 
past object is the spell, so lets find the best talisman for that.  Oh, user is 
using a a lockpicking skill - lets find best item for that, etc)'.

  So I think the fix is the best way to go - player can decide what 
talisman/holy symbol to use, or can just use the native skill they have if they 
select nothing.


_______________________________________________
crossfire-devel mailing list
     
     crossfire-devel at lists.real-time.com
     
     
     https://mailman.real-time.com/mailman/listinfo/crossfire-devel