The one suggestion I would have for the changes is to print a message in red (or other noticable color) to the extent of 'bound command is being truncated'. Otherwise, if someone is binding 250 characters, they may not notice that it has been shortened (less likely to look close on such a long line). crossfire-cvs-admin at lists.sourceforge.net wrote: > Module Name: client > Committed By: onefang > Date: Mon Jan 12 07:20:00 UTC 2004 > > Modified Files: > client/gnome: gnome.c > > Log Message: > Bind commands longer than the bind buffer no longer crash. > DVS 2004-01-12 > > > > Start of context diffs > > > Index: client/gnome/gnome.c > diff -c client/gnome/gnome.c:1.3 client/gnome/gnome.c:1.4 > *** client/gnome/gnome.c:1.3 Mon Nov 10 07:11:19 2003 > --- client/gnome/gnome.c Sun Jan 11 23:20:00 2004 > *************** > *** 935,940 **** > --- 935,943 ---- > draw_info("Try unbind to remove bindings..", NDI_BLACK); > return; > } > + if (strlen(params) >= sizeof(bind_buf)) { > + params[sizeof(bind_buf) - 1] = '\0'; > + } > sprintf(buf, "Push key to bind '%s'.", params); > draw_info(buf, NDI_BLACK); > strcpy(bind_buf, params); > > > ------------------------------------------------------- > This SF.net email is sponsored by: Perforce Software. > Perforce is the Fast Software Configuration Management System offering > advanced branching capabilities and atomic changes on 50+ platforms. > Free Eval! http://www.perforce.com/perforce/loadprog.html > _______________________________________________ > Crossfire-cvs mailing list > Crossfire-cvs at lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/crossfire-cvs _______________________________________________ crossfire-devel mailing list crossfire-devel at lists.real-time.com https://mailman.real-time.com/mailman/listinfo/crossfire-devel