[CF-Devel] become_follower patch

[crossfire-devel at archives.real-time.com]

Karla Stenger wrote:
>
     
      Hi all,
     
     >
     
     
     >
     
      This patch makes sure the praying skill is actually applied when calling the
     
     >
     
      change_abil function and then returns the skill to it's previous
     
     >
     
      applied/unapplied status.
     
     >
     
     
     >
     
      Solves the problem of getting the wrong message when becomming a follower of a
     
     >
     
      certain god which should give you a certain ability instead of taking it away.
     
     
  Basically looks fine.

  Only minor quibble is there is no need to check the flag status before setting 
it.  EG, instead of:

        if (!QUERY_FLAG(skop, FLAG_APPLIED))
                SET_FLAG(skop,FLAG_APPLIED);

this is equivalant:

	SET_FLAG(skop,FLAG_APPLIED);

  And depending on the compiler, potentially faster- certainly not any slower.

  Not really much an issue in this case (performance wise), but just a minor 
style point.


_______________________________________________
crossfire-devel mailing list
     
     crossfire-devel at lists.real-time.com
     
     
     https://mailman.real-time.com/mailman/listinfo/crossfire-devel