ATTN. DEVS, SERIOUS BUG (Re: [CF-Devel] Archetypes, New maps, Idease?)

crossfire-devel at archives.real-time.com crossfire-devel at archives.real-time.com
Fri Oct 1 15:23:08 CDT 2004


Found typos in the bronze weapon arches I added, fixed

now, also treasure list has all it's
whitespace+newline lines removed.

     
     https://cat2.ath.cx/crossfirearch
     
     

Note: the cat2 dev server is back up.

Sorry to the dev who wrote the map loading code, the
problem wasn't there but in the treasure list code
aswell as my arches (I felt the wrath of both problems
:
     
     P, glad we found the code problem tho)
     
     
--- Mitch Obrian <
     
     mikeeusaaa at yahoo.com
     
     > wrote:

>
     
      Well glad it is something that is now found and can
     
     >
     
      be
     
     >
     
      fixed :D.
     
     >
     
     
     >
     
      @caethaver2:~/cvs/crossfire]$ locale
     
     >
     
      LANG=POSIX
     
     >
     
      LC_CTYPE="POSIX"
     
     >
     
      LC_NUMERIC="POSIX"
     
     >
     
      LC_TIME="POSIX"
     
     >
     
      LC_COLLATE="POSIX"
     
     >
     
      LC_MONETARY="POSIX"
     
     >
     
      LC_MESSAGES="POSIX"
     
     >
     
      LC_PAPER="POSIX"
     
     >
     
      LC_NAME="POSIX"
     
     >
     
      LC_ADDRESS="POSIX"
     
     >
     
      LC_TELEPHONE="POSIX"
     
     >
     
      LC_MEASUREMENT="POSIX"
     
     >
     
      LC_IDENTIFICATION="POSIX"
     
     >
     
      LC_ALL=
     
     >
     
     
     >
     
      --- Lalo Martins <
      
      lalo at laranja.org
      
      > wrote:
     
     >
     
     
     >
     
      > Congratulations, you found a legitimate - and
     
     >
     
      > possibly dangerous
     
     >
     
      > - bug in the server :-/
     
     >
     
      > 
     
     >
     
      > what is your libc and locale?  I have glibc 2.3.4
     
     >
     
      > (20040808) and
     
     >
     
      > lalo:~SRC/crossfire/server/=build/server> locale
     
     >
     
      > LANG=
     
     >
     
      > LC_CTYPE=pt_BR
     
     >
     
      > LC_NUMERIC="POSIX"
     
     >
     
      > LC_TIME="POSIX"
     
     >
     
      > LC_COLLATE="POSIX"
     
     >
     
      > LC_MONETARY="POSIX"
     
     >
     
      > LC_MESSAGES="POSIX"
     
     >
     
      > LC_PAPER="POSIX"
     
     >
     
      > LC_NAME="POSIX"
     
     >
     
      > LC_ADDRESS="POSIX"
     
     >
     
      > LC_TELEPHONE="POSIX"
     
     >
     
      > LC_MEASUREMENT="POSIX"
     
     >
     
      > LC_IDENTIFICATION="POSIX"
     
     >
     
      > LC_ALL=
     
     >
     
      > 
     
     >
     
      > 
     
     >
     
      > The culprit is that, at line 118 of treasure.c,
     
     >
     
      > isspace() is
     
     >
     
      > skipping over the \0 that should signal end of
     
     >
     
      > string.  So, a
     
     >
     
      > line in the treasures file consisting of only
     
     >
     
      > whitespace (which
     
     >
     
      > your file does have) crashes the server.
     
     >
     
      > 
     
     >
     
      > I'd submit a patch, but I'm still pondering on the
     
     >
     
      > right fix.
     
     >
     
      > 
     
     >
     
      > []s,
     
     >
     
      >                                               
     
     >
     
      |alo
     
     >
     
      >                                               
     
     >
     
      +----
     
     >
     
      > --
     
     >
     
      >             Those who trade freedom for security
     
     >
     
      >                lose both and deserve neither.
     
     >
     
      > --
     
     >
     
      > 
      
      http://www.laranja.org/
      
      
     >
     
      > mailto:
      
      lalo at laranja.org
      
      
     >
     
      >  pgp key:
     
     >
     
      >
     
     >
     
     
      http://garfield.laranja.org/~lalo/gpgkey-signed.asc
      
      
     >
     
      > 
     
     >
     
      > GNU: never give up freedom                
     
     >
     
      > 
      
      http://www.gnu.org/
      
      
     >
     
      > 
     
     >
     
      > _______________________________________________
     
     >
     
      > crossfire-devel mailing list
     
     >
     
      > 
      
      crossfire-devel at lists.real-time.com
      
      
     >
     
      >
     
     >
     
     
     
     https://mailman.real-time.com/mailman/listinfo/crossfire-devel
     
     
>
     
      > 
     
     >
     
     
     >
     
     
     >
     
     
     >
     
     
     >
     
      __________________________________
     
     >
     
      Do you Yahoo!?
     
     >
     
      Yahoo! Mail - Helps protect you from nasty viruses.
     
     >
     
     
      http://promotions.yahoo.com/new_mail
      
      
     >
     
     
     >
     
      _______________________________________________
     
     >
     
      crossfire-devel mailing list
     
     >
     
     
      crossfire-devel at lists.real-time.com
      
      
     >
     
     
     
     https://mailman.real-time.com/mailman/listinfo/crossfire-devel
     
     
>
     
     
     


		
__________________________________
Do you Yahoo!?
New and Improved Yahoo! Mail - Send 10MB messages!
     
     http://promotions.yahoo.com/new_mail
     
      

_______________________________________________
crossfire-devel mailing list
     
     crossfire-devel at lists.real-time.com
     
     
     https://mailman.real-time.com/mailman/listinfo/crossfire-devel
     
     
    


More information about the crossfire mailing list