[CF-Devel] Ready to start contributing

[crossfire-devel at archives.real-time.com]

Mark Wedel wrote:
>
     
      Ideally, other people could also review the patches that are submitted
     
     >
     
      by sourceforge, and apply if they look good.
     
     
I started with the patch

  [ 1022962 ] Rare book name overrun

(Reviewed, tested and committed it.)

But I could not find out how to change the state of the sourceforge
tracker items. Should I just add a comment to that tracker item (and
wait for someone else to change the state) or did I miss anything?


Basically, the problem was a statement like

  sprintf(buf, "...%s...", buf)

That is, the destination string was part of the source string. Doing a
grep for all s[n]printf calls in the code revealed some more statements
like

  sprintf(buf, "%s...", buf)

in readable.c. Should I change these statements as well? (I ask this
because these statements may work in practice, but the Ansi-C standard
says "If copying takes place between objects that overlap, the behavior
is undefined.")

_______________________________________________
crossfire-devel mailing list
     
     crossfire-devel at lists.real-time.com
     
     
     https://mailman.real-time.com/mailman/listinfo/crossfire-devel