[crossfire] channels

[tchize]

Hello, i saw this in channels, file c_chat.c:
{"literature", 5, "The contents of signs, scrolls, and other written 
texts.",1},

I admit, have not yet tested your patch, and specially it's integration with 
the one am currently writing about readables. However, looks like the 
suggested change is may conflict, in the literature part, with the one am 
working on.
Let me explain.
Reading of signs, books, monuments, letters, aso, is a pain to manipulate for 
client as there is no specialized way of sending those. If you want you 
client to show you a nice book picture with the text written on it, you have 
to parse server message and catch all the 'you open the ? and start 
reading.', same problem if you want to draw a scroll, a letter, a sign, and 
so on.

The patch am working on is based on a subscribe/notify paradigm, not made to 
handle channels like yours, as i think this is a different part and you are 
doing quite well in it, but made to identify all kinds of readables send to 
client by sending them with another command than draw_info. The client 
subscribe to the server for the send of specialized data. Client can 
subscribe to receiving books in a special way, subscribe to receiving signs 
in a special way, subscribe to receiving motd in a special way, ...

Now, if your patch, in this part, is just about telling server 'send me or do 
not send me literature' there will be no conflict in code logic and there 
will in fact be complementarity.
But if your patch is about 'send me literature in a way so client can identify 
it as literature' there will be a conflict of use.
According to the messages on the bugtrack, you are in the first case 
(replacing the listen level to let client tell server what may and what may 
not be send), but i just want to be sure about it before your patch make his 
way to the cvs :)

Regards,
Tchize

--
Tchize (David Delbecq)
     
     tchize at myrealbox.com
     
     
Public PGP KEY FINGERPRINT:
    F4BC EF69 54CC F2B5 4621  8DAF 1C71 8E6B 5436 C17C
Public PGP KEY location:
    
     
     http://wwwkeys.pgp.net/pgpnet/wwwkeys.html
     
     
Le Dimanche 24 Avril 2005 02:52, Brendan Lally a écrit :
I've attached a rather bulky patch to casper's RFE at
     
     http://sourceforge.net/tracker/index.php?func=detail&aid=1183961&group_id=138
     
     
33&atid=363833

It is now at a state that it can be considered ready for wider
 review/testing.

If there is anyone who has time on their hands, there are two versions, one
 is the patch itself, one is a diff of only the files that have code changes,
 and is therefore sane to attempt to read. (as well as being less likely to
 break next server code update :) )

Any comments would be greatly appreciated.

_______________________________________________
crossfire mailing list
     
     crossfire at metalforge.org
     
     
     http://mailman.metalforge.org/mailman/listinfo/crossfire
     
     

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : 
     
     http://shadowknight.real-time.com/pipermail/crossfire/attachments/20050424/7c576f0e/attachment.pgp