[CF-Devel] Re: [Crossfire-cvs] CVS commit: crossfire

[crossfire-devel at archives.real-time.com]

Andreas Kirschbaum wrote:
>>
     
     Index: crossfire/server/time.c
     
     >
     
     
     >
     
      [...]
     
     >
     
     
     >>
     
     +           if (get_map_flags(m, &m, nx, ny, &nx, &ny) == P_OUT_OF_MAP) {
     
     >
     
     
     >
     
     
     >
     
      This change does not look right to me. At least, it is inconsistent with
     
     >
     
      other checks of the P_OUT_OF_MAP flag: all other checks are done like
     
     >
     
      "if(get_map_flags() & P_OUT_OF_MAP)". (That is, treating P_OUT_OF_MAP as
     
     >
     
      a bit in the result value.)
     
     
  I'll change it.

  fundamentally, it is correct - if the coordinate is out of the map, the 
function will return P_OUT_OF_MAP without it being bitmasked with any other values.

  other returns from get_map_flags() can be bitmasked (eg, P_BLOCKED | P_MAGIC 
or the like).

  But certainly good to be consistent.


_______________________________________________
crossfire-devel mailing list
     
     crossfire-devel at lists.real-time.com
     
     
     https://mailman.real-time.com/mailman/listinfo/crossfire-devel