[crossfire] A few random ideas

Andreas Kirschbaum kirschbaum at myrealbox.com
Tue Jul 19 15:32:55 CDT 2005


Nicolas Weeger wrote:
>
     
      Ok, just committed code to do just that. New item type,
     
     >
     
      ITEM_TRANSFORMER (163). Just a special item, that when applied grabs
     
     >
     
      the marked item. 'slaying' field is checked to transform if eligible.
     
     
I've just added support for this item to the Java Editor.


>
     
      The use of 'slaying' is discutable, of course :)
     
     
This indeed is a problem for the Java Editor. Therefore I just did not
define that field for all items. I just mentioned the 'slaying' field
for the 'victim' item in the help message of the item transformer. So
you have to manually add the slaying field to the victim items but
cannot simply use an edit box.


Furthermore I have the following questions/suggestions:

 * The comment for apply_item_transformer() says "Created item is in the
   'other_arch' field". But neither the implementation nor the
   documentation in doc/Developers/item_transformation does use it.

   Does that mean the comment is wrong (and should be removed), or is
   the implementation incomplete (and should create a new item)?

 * The currently existing "slicingknive" has client type 101 (edged
   weapon) but cannot be used as a weapon. I'd rather change that to say
   8030 (misc item).

 * The use of "level" for the "number of uses" seems inconsistent to me:
   other items use either "hp" (Creator, Mover, Rune, Trap) or "food"
   (Magic Mouth, Wand/Staff, Lighter) for this information.

   Besides that, I'd rather change that field to be a counter ("number
   of remaining uses") than leave it as a boolean ("destroy item if
   used").

    
    


More information about the crossfire mailing list