[crossfire] Re: [Crossfire-cvs] CVS commit: client

[Andreas Kirschbaum]

crossfire-cvs-admin at lists.sourceforge.net wrote:
> Module Name:	client
> Committed By:	ryo_saeba
> Date:		Tue Dec 27 14:26:29 UTC 2005
[...]
> Log Message:
> Make nrof uint32, like server-side. Fix a crash with get_number.
[...]
> ! char *get_number(uint32 i) {
[...]
> +   if(i<0)
> +   {
> + 	  sprintf(buf,"negative");
> + 	  return buf;
> +   }

This check does not make sense to me: the variable i is a unsigned
variable. Therefore the value never is negative, hence this code will
never be executed.