[crossfire] Newly modified spring_trap() passes uninitialized ptr and crashes server.

Alex Schultz alex_sch at telus.net
Wed Oct 4 23:33:19 CDT 2006


Kevin R. Bulgrien wrote:
> Uninitialized ptr... env in spring_trap is passed to get_rangevector and is
> used without checking it first.
>
>         http://rafb.net/paste/results/nHaX0I34.html
>
> Revision 4979 modified spring_trap() 8 days, 20 hours ago
>
> get_rangevector() call was moved up before env was initialized and
> get_rangevector() assumes the pointer is good and uses it.
>
> http://svn.sourceforge.net/viewvc/crossfire/server/branches/1.x/server/rune.c?view=diff&r1=4978&r2=4979
Ack, sorry about that. My mistake. Fixing that now.

Alex Schultz



More information about the crossfire mailing list