[crossfire] Handling of "Created" and "Modified" info in map headers

Raphaël Quinet raphael at gimp.org
Mon Aug 25 13:39:46 CDT 2008


Hi,

I noticed a difference between how gridarta updates the map headers
and how my patched version of gcrossedit handles it:

- gcrossedit handles the "Created" and "Modified" fields like a
  ChangeLog, appending a new "Modified" line whenever a change is
  made and the date or author doesn't match the previous entry.

- gridarta seems to always replace the first "Modified" line,
  regardless of what was there before.

The fact that gridarta only considers the first "Modified" entry
and ignores the other ones leads to strange situations, like in
this example with /darcap/darcap/circus/fz_olobby:

Revision 9710 looked like this:

Created:  2008-07-24 Chad Opperman | cromagic at sbcglobal.net
Modified: 2008-07-26 Chad Opperman | cromagic at sbcglobal.net
Modified: 2008-08-01 Raphaël Quinet

After editing (presumably with gridarta), r9751 looks like this:

Created:  2008-07-24 Chad Opperman | cromagic at sbcglobal.net
Modified: 2008-08-18 Rick Tanner
Modified: 2008-08-01 Raphaël Quinet

The second "Modified" entry is still there, but the first one has
been replaced, resulting in dates that are in the wrong order.


What should be the appropriate behavior in this case?  Should there
be only one "Modified" line in each map header (in which case both
gridarta and gcrossedit should be modified to delete other lines)
or should "Modified" lines be collected like a mini ChangeLog (in
which case gridarta should be modified to append instead of replacing
the first "Modified" line)?

Personally, I like the mini ChangeLog approach because it can give
useful clues about the history of the map to those who get the mapinfo
without having SVN access.  This is also useful if a map goes through
several iterations before being imported in SVN, or when external
contributors submit patches without having SVN access.  But I could
also understand the desire to keep the map header small and only keep
a single "Modified" line.

-Raphaël



More information about the crossfire mailing list