[crossfire] Item merging bug

[Mark Wedel]

On 09/ 2/10 09:51 AM, Nicolas Weeger wrote:
>>    As I think about this, I believe the main use of overlays was the weather
>> code - so that when it put snow effects, etc, it could know what objects
>> were original to the map (eg, the base mountain) and which objects were
>> put on top by weather effects.
>>
>>    I believe the reason for this is so that the base map (say the scorn
>> town) could reset, but the weather effects would persist across that
>> reset.
>>
>>    I don´t think anything is using the weather code - I´m not even sure to
>> what extent it still works.
>
> The weather code was removed years ago in trunk.
>
> So I guess that makes overlays removable? :)
>
>
> Though it can be useful in some cases, like for DMs wanting to leave items
> persisting resets.

  True.

  It just seems to me that the implementation is buggy - if on a unique map, it 
shouldn´t be setting the flag_original value - maybe that is a simpler map - to 
check for that and not set it.