[crossfire] [PATCH 0/1] GTK 2+ client: fix for locale dir. reference in Makefile.am; other autotools issues

[David McIlwraith]

The SVN trunk version of the client at
"https://crossfire.svn.sourceforge.net/svnroot/crossfire/client/trunk"
(current rev.: 15869, applies cleanly) is being employed, with "patch
-Np0 < [path to patch]" in the 'client' directory. Not sure what the
problem is there. crossfire-client version 1.60.0 has an additional
bug re: curl/types.h header inclusion; this does not exist in newer
cURL versions, and is not required. A patch for that is attached.

Regards,
- David McIlwraith <archaios at archaios.net>

On Sun, Dec 4, 2011 at 11:44 AM, James Lopeman <meflin at meflin.net> wrote:
> The attached patch does not apply for me, even with some fixes.
>
> Meflin
>
> On Saturday, December 03, 2011 05:33:58 PM James Lopeman wrote:
>> I do not know enough about automess to comment on this other then I
>> apreciate the feedback ( and patches even more ) from a distro.
>>
>> Have you considered packaging jxclient? At this time it is the most
>> advanced client.
>>
>> Meflin
>>
>> On Saturday, December 03, 2011 04:27:55 PM David McIlwraith wrote:
>> > Ouch -- Sorry for the duplicate messages! Accidental resend.
>> >
>> > Regards,
>> > - David McIlwraith <archaios at archaios.net>
>> >
>> > On Sun, Dec 4, 2011 at 10:24 AM, David McIlwraith <2c93e8f1 at gmail.com>
>>
>> wrote:
>> > > Hi,
>> > >
>> > > As of the newest trunk svn version (and prior versions), the locale
>> > > directory is not properly referenced in 'gtk-v2/src/Makefile.am',
>> > > leading to "$prefix/locale" (via an unset "$(DATADIRNAME), which
>> > > should be "$datadir") being used instead of "$prefix/$datadir/locale"
>> > > (noting that "$localedir", I believe, is the correct setting, and
>> > > succeeds in my tests; see patch below), even though NLS is currently
>> > > not employed. I propose the patch in the next message.
>> > >
>> > > As a secondary issue, as use of 'autogen.sh' is deprecated (per
>> > > warning), and the included 'aclocal.m4' is out-of-date [if autoconf
>> > > 2.61 is not used], I must advise that the package fails to build on
>> > > (at least) the current ArchLinux distribution via use of 'autoreconf'
>> > > alone, as 'utils/{config.guess,config.sub,install-sh,missing}' are not
>> > > provided.
>> > >
>> > > The commands:
>> > >
>> > > aclocal
>> > > automake --add-missing [to add the missing utils/ files]
>> > > autoreconf
>> > >
>> > > are necessary to produce a working package. I am not sure if the
>> > > latter problem is regarded as a major issue at this point or not, but
>> > > the locale directory reference is definitely not correct with current
>> > > autotools versions.
>> > >
>> > > Regards,
>> > > - David McIlwraith <archaios at archaios.net>
>> > > ArchLinux AUR 'crossfire-client' / 'crossfire-client-svn' package
>> > > maintainer
>> >
>> > _______________________________________________
>> > crossfire mailing list
>> > crossfire at metalforge.org
>> > http://mailman.metalforge.org/mailman/listinfo/crossfire
>>
>> _______________________________________________
>> crossfire mailing list
>> crossfire at metalforge.org
>> http://mailman.metalforge.org/mailman/listinfo/crossfire
> _______________________________________________
> crossfire mailing list
> crossfire at metalforge.org
> http://mailman.metalforge.org/mailman/listinfo/crossfire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: crossfire-curl-rm-types-h-dep.patch
Type: text/x-patch
Size: 300 bytes
Desc: not available
URL: <http://mailman.metalforge.org/pipermail/crossfire/attachments/20111204/df1166bc/attachment.bin>