[crossfire] Player creation bug

[Tolga Dalman]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

(resending to the list)

On 22.02.2011 07:55, Mark Wedel wrote:
> > On 02/13/11 03:47 AM, Tolga Dalman wrote:
>> >> - - create new character: fire hatchling/monk
>> >> - - maximize str, dex and con
>> >> - - set remaining stats so that they are 1 in total
>> >> - - distribute the remaining points to pow
>> >>
>> >> This will fail, because the stats are checked after applying the
>> >> race (but not the class). The attached patch fixes this issue.
> >
> >  I'm not quite sure if I understand the problem or not.
> >
> >  I tried to do that, and got a message saying stat to low.  That is
> > correct behavior IMO.

Why is that correct ? Having total stats with at least 1 point should
not yield an error! The attached patch removes the first (and thus
redundant) stat check.

> >  I also think this is needed for balance - if a class has a big stat
> > penalty, you need to spend some points to offset that penalty.  If one
> > does not need to spend any points to offset penalties, then the
> > penalties become a lot less meaningful (don't put any points, and the
> > fact there is a -8 penalty doesn't mean anything)
Agreed. However, this could be automated.

>> >> Being on this topic, I have some suggestions for the crossfire-client.
>> >> I think it is already pretty good, however for a normal user like
>> >> me it is quite difficult to create a character in a sane way.
>> >> So I suggest:
>> >> 1. add descriptions for stats (e.g. tooltips).
> >
> >  Already there - at least they work for me.
Strange. Then this is considered a bug in the client :)

>> >> 4. disallow negative unspent stat points. This should be a simple
>> >> check in the
>> >>     '+' buttons.
> >
> >  And conversely, on point #4, that compounds the issue.  Eg, I select
> > troll, it updates the stats to minimum values - now I have negative stat
> > points.  So now it goes and decreases the high stats to make things
> > legal.  If I go back to human, then those stat values are really nothing
> > close to what I had put in before.
> >
> >  I'm not 100% sure what is the best way here - each one has its pros and
> > cons.  My initial implementation of that was to make it very easy to
> > experiment with different combos, which means it does allow illegal
> > values when playing around.
While it is great for a developer not to have automatic attribute
adjustments, for a user it does not make any sense.


>> >> 5. "Choose starting map" should be replaced by the actual drop-down
>> >> menu with
>> >>     "Scorn" as default value.
> >
> >  I had issues fitting the description in.  I had also thought that maybe
> > at some point, that even gets extended with an image of some sort
> > representing the map choice.
I understand. Why not add another button for detail information on the
particular choice ?

Thanke & best regards
Tolga Dalman


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJNY32jAAoJEI0vwg8AaIlUnLQH/RjGibZhwgCALAxhFufa4q3x
N7z719Hr05Z6lCCWIS74mfETEMjFV3ml0Xe4hHwU9n+87SibRB3vVG/IgzPGBsEz
vMn0FxETCmrZKCMvvvAC0tWg9f+x7z+WwuXb6AM8VCjIvSqKUe4CIGErzIRA4a1M
lnxMH2mbEIdyXO4nWH35BfwG8/TgGpdMRjTRUzwYnTouR2hNtH3k5SXOnzRVdeHX
tqBXbz5KEMKKZ3OP+ESs0WfLbjLDu9PG2IA0jMjr084GcR0KRQhfp/Zl45EosF6l
8LZcM9lf3kQENO41v+/7rhpch0KHndhkbYfsE++baroD/+/w6L5/xC0OAoMSJO4=
=CqkP
-----END PGP SIGNATURE-----