[crossfire] [PATCH 1/2] Keybindings: multiple changes

Arvid Brodin arvidb at kth.se
Sat Nov 2 18:24:04 CDT 2013


* Show all keybindings (incl default ones) in both 'unbind' and the keybindings
  dialog. (Should reduce confusion for new users.)
    
* Add "Any" key modifier type; New "Any" button in keybindings dialog. This lets
  the user choose between having a key work regardless of modifier (Run, Alt, etc)
  key states, or to use the same key with different modifiers for different
  bindings. How this worked before ("All"/"Normal") was pretty unclear, even in the
  code comments. (New feature/bug fix.)
    
* Consistent use of hash helper functions (keybind_insert(), keybind_remove(),
  etc). This should make the code more maintainable and reduce the risk of bugs.
    
* Better usage texts (among other things they used '[' which was interpreted as
  a style tag, making parts of the usage text go missing). (Bug fix.)
    
* Bind only lowercase keys - we handle Shift state separately. (Bug fix.)
   
* Rehash keybind entry on key dialog update (fixes bug where keybinding with
  modified keyval would become unusable until restart). (Bug fix.)
  
* Removed -afmnr flags from 'bind' - instead use only "press the key combo you
  want" when you bind the key. This is to simplify the keybind without removing
  any real functionality.

-- 
Arvid
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-keybinding-multiple-changes.patch
Type: text/x-patch
Size: 57671 bytes
Desc: not available
URL: <http://mailman.metalforge.org/pipermail/crossfire/attachments/20131103/4163ea2c/attachment.bin>


More information about the crossfire mailing list