From pc-crossfire06 at crowcastle.net Wed Apr 12 20:07:49 2023 From: pc-crossfire06 at crowcastle.net (Preston Crow) Date: Wed, 12 Apr 2023 21:07:49 -0400 Subject: [crossfire] Scorn Smith Message-ID: <941801e2-ac0b-74fc-850c-ceb23c6cf5a5@crowcastle.net> I think the smith in Scorn is broken.  He took my shield and money, but is never able to finish. While I have local changes, I don't think anything impacts this. I see this in the logs: 23/04/12 21:05:41 [DD] CFPython: running script /usr/games/crossfire/share/crossfire/maps/python/dialog/npc_dialog.py 23/04/12 21:05:41 [DD] CFPython: Loading NPC dialog /usr/games/crossfire/share/crossfire/maps/scorn/shops/smith.msg 23/04/12 21:05:41 [EE] CFPython: CFDialog: Failed to evaluate condition ['age', 'orderplaced', '0', '0', '1', '0', '0']: name 'Crossfire' is not defined. 23/04/12 21:05:41 [DD] CFPython: Ignoring NPC dialog from ['smith_finished.msg'], conditions not met This is on the crowcastle.com server. Is this working elsewhere? I have python 3.9 in case that matters. From leaf at real-time.com Wed Apr 12 23:48:26 2023 From: leaf at real-time.com (Rick Tanner) Date: Wed, 12 Apr 2023 23:48:26 -0500 Subject: [crossfire] Scorn Smith In-Reply-To: <941801e2-ac0b-74fc-850c-ceb23c6cf5a5@crowcastle.net> References: <941801e2-ac0b-74fc-850c-ceb23c6cf5a5@crowcastle.net> Message-ID: <3f309684-f941-783a-2e81-7ddeb9f70073@real-time.com> I am encountering the same issue with the Scorn smith in latest code base, v1.75.0-1235-gcda2dd221 From nicolas.weeger at laposte.net Thu Apr 13 12:49:24 2023 From: nicolas.weeger at laposte.net (Nicolas Weeger) Date: Thu, 13 Apr 2023 19:49:24 +0200 Subject: [crossfire] Scorn Smith In-Reply-To: <941801e2-ac0b-74fc-850c-ceb23c6cf5a5@crowcastle.net> References: <941801e2-ac0b-74fc-850c-ceb23c6cf5a5@crowcastle.net> Message-ID: <599eff5c-ec66-72a3-5841-78205828c634@laposte.net> Hello. Thanks for the bug report :) It should be fixed on SF now. Best regards Nicolas Le 13/04/2023 à 03:07, Preston Crow a écrit : > I think the smith in Scorn is broken.  He took my shield and money, > but is never able to finish. > > While I have local changes, I don't think anything impacts this. I see > this in the logs: > > 23/04/12 21:05:41 [DD] CFPython: running script > /usr/games/crossfire/share/crossfire/maps/python/dialog/npc_dialog.py > 23/04/12 21:05:41 [DD] CFPython: Loading NPC dialog > /usr/games/crossfire/share/crossfire/maps/scorn/shops/smith.msg > 23/04/12 21:05:41 [EE] CFPython: CFDialog: Failed to evaluate > condition ['age', 'orderplaced', '0', '0', '1', '0', '0']: name > 'Crossfire' is not defined. > 23/04/12 21:05:41 [DD] CFPython: Ignoring NPC dialog from > ['smith_finished.msg'], conditions not met > > This is on the crowcastle.com server. > > Is this working elsewhere? > > I have python 3.9 in case that matters. > > _______________________________________________ > crossfire mailing list > crossfire at metalforge.org > http://mailman.metalforge.org/mailman/listinfo/crossfire > IRC: http://crossfire.real-time.com/irc/index.html > Discord: http://crossfire.real-time.com/discord/index.html > Project Site: https://sourceforge.net/projects/crossfire/ > Wiki: http://wiki.cross-fire.org/ > Website: http://crossfire.real-time.com From pc-crossfire06 at crowcastle.net Fri Apr 14 10:36:22 2023 From: pc-crossfire06 at crowcastle.net (Preston Crow) Date: Fri, 14 Apr 2023 11:36:22 -0400 Subject: [crossfire] metaserver differences and code Message-ID: <3156944e-ae62-8c57-9748-0d8bc5785675@crowcastle.net> https://crossfire.real-time.com/metaserver-info/index.html The above page and the code reference three active metaservers, the Primary, European, and US mirrors.  Looking at the servers they list, they're surprisingly different.  I know my server, crowcastle.com, is sending updates to all three without any errors, but only shows up on the EU mirror. Is something broken? I've been looking in the server code, and I don't see anything that would explain the issue.  I do get a ton of compiler warnings about deprecated curl interfaces, but I'm not touching that both because I'm not familiar with the library and because I'm afraid of breaking things because I don't know if anyone is depending on an older version that doesn't have the new interfaces.  If we're intentionally not updating, then perhaps add -Wno-deprecated to the makefile for that module. From ruben at mrbrklyn.com Fri Apr 14 11:28:51 2023 From: ruben at mrbrklyn.com (Ruben Safir) Date: Fri, 14 Apr 2023 12:28:51 -0400 Subject: [crossfire] metaserver differences and code In-Reply-To: <3156944e-ae62-8c57-9748-0d8bc5785675@crowcastle.net> References: <3156944e-ae62-8c57-9748-0d8bc5785675@crowcastle.net> Message-ID: <20230414162851.GA26784@www2.mrbrklyn.com> I can be a mirror if yu need more On Fri, Apr 14, 2023 at 11:36:22AM -0400, Preston Crow wrote: > https://crossfire.real-time.com/metaserver-info/index.html > > The above page and the code reference three active metaservers, the > Primary, European, and US mirrors.  Looking at the servers they > list, they're surprisingly different.  I know my server, > crowcastle.com, is sending updates to all three without any errors, > but only shows up on the EU mirror. > > Is something broken? > > I've been looking in the server code, and I don't see anything that > would explain the issue.  I do get a ton of compiler warnings about > deprecated curl interfaces, but I'm not touching that both because > I'm not familiar with the library and because I'm afraid of breaking > things because I don't know if anyone is depending on an older > version that doesn't have the new interfaces.  If we're > intentionally not updating, then perhaps add -Wno-deprecated to the > makefile for that module. > > _______________________________________________ > crossfire mailing list > crossfire at metalforge.org > http://mailman.metalforge.org/mailman/listinfo/crossfire > IRC: http://crossfire.real-time.com/irc/index.html > Discord: http://crossfire.real-time.com/discord/index.html > Project Site: https://sourceforge.net/projects/crossfire/ > Wiki: http://wiki.cross-fire.org/ > Website: http://crossfire.real-time.com -- So many immigrant groups have swept through our town that Brooklyn, like Atlantis, reaches mythological proportions in the mind of the world - RI Safir 1998 http://www.mrbrklyn.com DRM is THEFT - We are the STAKEHOLDERS - RI Safir 2002 http://www.nylxs.com - Leadership Development in Free Software http://www2.mrbrklyn.com/resources - Unpublished Archive http://www.coinhangout.com - coins! http://www.brooklyn-living.com Being so tracked is for FARM ANIMALS and extermination camps, but incompatible with living as a free human being. -RI Safir 2013 From leaf at real-time.com Fri Apr 14 13:39:58 2023 From: leaf at real-time.com (Rick Tanner) Date: Fri, 14 Apr 2023 13:39:58 -0500 Subject: [crossfire] metaserver differences and code In-Reply-To: <3156944e-ae62-8c57-9748-0d8bc5785675@crowcastle.net> References: <3156944e-ae62-8c57-9748-0d8bc5785675@crowcastle.net> Message-ID: <7df52a0a-0265-2f15-662a-abc7f6a84980@real-time.com> Log files do not or has not provided any insight as to why the US metaservers are not displaying all servers. On a different note, the metaserver code needs to migrate to PHP8 someday. Or, move forward with testing and rollout of the node.js based metaserver available at https://sourceforge.net/p/crossfire/patches/361/ ? From leaf at real-time.com Fri Apr 14 15:00:24 2023 From: leaf at real-time.com (Rick Tanner) Date: Fri, 14 Apr 2023 15:00:24 -0500 Subject: [crossfire] metaserver differences and code In-Reply-To: <3156944e-ae62-8c57-9748-0d8bc5785675@crowcastle.net> References: <3156944e-ae62-8c57-9748-0d8bc5785675@crowcastle.net> Message-ID: Another note... https://sourceforge.net/p/crossfire/metaserver/ci/master/tree/meta_update.php#l40 Which is: // Basically, either forward or reverse addressing must work - // if the ip that the user specified hostname resolves to does // not match that of the incoming connection, or the hostname based // on the ip of the incoming connection does not match that specified // by the server, we reject this user - no spoofing of other servers // allowed. if ($ip != $_SERVER['REMOTE_ADDR'] && $hostname != $_POST['hostname']) { echo "neither forward nor reverse DNS look corresponds to incoming ip address.\n"; echo "incoming ip: " . $_SERVER['REMOTE_ADDR'] . ", DNS of that: $hostname\n"; echo "User specified hostname: " . $_POST['hostname'] . " IP of that hostname: $ip\n"; log_message(LOG_WARN, $_SERVER['REMOTE_ADDR'] . " does not have correct hostname set\n"); exit; } And find this: $ dig crossfire.crowcastle.com crowcastle.com. 173.48.158.241 $ dig -x 173.48.158.241 pool-173-48-158-241.bstnma.fios.verizon.net. From pc-crossfire06 at crowcastle.net Fri Apr 14 15:15:37 2023 From: pc-crossfire06 at crowcastle.net (Preston Crow) Date: Fri, 14 Apr 2023 16:15:37 -0400 Subject: [crossfire] metaserver differences and code In-Reply-To: References: <3156944e-ae62-8c57-9748-0d8bc5785675@crowcastle.net> Message-ID: Ahh, I'm running on my home fibre connection.  That explains why the metaserver might not like me. On 4/14/23 16:00, Rick Tanner wrote: > > Another note... > > https://sourceforge.net/p/crossfire/metaserver/ci/master/tree/meta_update.php#l40 > > > Which is: > > // Basically, either forward or reverse addressing must work - > // if the ip that the user specified hostname resolves to does > // not match that of the incoming connection, or the hostname based > // on the ip of the incoming connection does not match that specified > // by the server, we reject this user - no spoofing of other servers > // allowed. > if ($ip != $_SERVER['REMOTE_ADDR'] && $hostname != $_POST['hostname']) { >     echo "neither forward nor reverse DNS look corresponds to incoming > ip address.\n"; >     echo "incoming ip: " . $_SERVER['REMOTE_ADDR'] . ", DNS of that: > $hostname\n"; >     echo "User specified hostname: " . $_POST['hostname'] . " IP of > that hostname: $ip\n"; >     log_message(LOG_WARN, $_SERVER['REMOTE_ADDR'] . " does not have > correct hostname set\n"); >     exit; > } > > > And find this: > > $ dig crossfire.crowcastle.com > crowcastle.com. > 173.48.158.241 > > $ dig -x 173.48.158.241 > pool-173-48-158-241.bstnma.fios.verizon.net. > _______________________________________________ > crossfire mailing list > crossfire at metalforge.org > http://mailman.metalforge.org/mailman/listinfo/crossfire > IRC: http://crossfire.real-time.com/irc/index.html > Discord: http://crossfire.real-time.com/discord/index.html > Project Site: https://sourceforge.net/projects/crossfire/ > Wiki: http://wiki.cross-fire.org/ > Website: http://crossfire.real-time.com > From leaf at real-time.com Fri Apr 14 16:43:14 2023 From: leaf at real-time.com (Rick Tanner) Date: Fri, 14 Apr 2023 16:43:14 -0500 Subject: [crossfire] metaserver differences and code In-Reply-To: References: <3156944e-ae62-8c57-9748-0d8bc5785675@crowcastle.net> Message-ID: <9704a17f-435f-7515-dfa1-32051b1e8f1d@real-time.com> Some local changes have been made on the US Metaserver for error tracking. http://metaserver.us.cross-fire.org/meta_html.php Now more servers are reporting or showing up on the US metaserver list. Some discoveries: archbase, mapbase, codebase are currently limited to 20 characters. Multiple servers exceed this 20 character limit. version field also has a 20 character limit, but with the new git version info, that exceeds the 20 character limit as well. The US Metaserver mirror was tweaked to allow 64 characters in those four fields, and that is when additional servers showed up. The hosting architecture for the EU Metaserver does not enforce the character limit on any fields, so this contributes to why more servers show up in that list then the primary metaserver (crossfire.real-time.com) and the US metaserver. From ruben at mrbrklyn.com Fri Apr 14 18:08:11 2023 From: ruben at mrbrklyn.com (Ruben Safir) Date: Fri, 14 Apr 2023 19:08:11 -0400 Subject: [crossfire] metaserver differences and code In-Reply-To: References: <3156944e-ae62-8c57-9748-0d8bc5785675@crowcastle.net> Message-ID: <1c2c9c63-c05b-c1b3-cd05-8e45cff6797f@mrbrklyn.com> On 4/14/23 16:15, Preston Crow wrote: > Ahh, I'm running on my home fibre connection.  That explains why the > metaserver might not like me. I have two free statics -- So many immigrant groups have swept through our town that Brooklyn, like Atlantis, reaches mythological proportions in the mind of the world - RI Safir 1998 http://www.mrbrklyn.com DRM is THEFT - We are the STAKEHOLDERS - RI Safir 2002 http://www.nylxs.com - Leadership Development in Free Software http://www.brooklyn-living.com Being so tracked is for FARM ANIMALS and extermination camps, but incompatible with living as a free human being. -RI Safir 2013 From leaf at real-time.com Fri Apr 21 02:58:05 2023 From: leaf at real-time.com (Rick Tanner) Date: Fri, 21 Apr 2023 02:58:05 -0500 Subject: [crossfire] metaserver differences and code In-Reply-To: <9704a17f-435f-7515-dfa1-32051b1e8f1d@real-time.com> References: <3156944e-ae62-8c57-9748-0d8bc5785675@crowcastle.net> <9704a17f-435f-7515-dfa1-32051b1e8f1d@real-time.com> Message-ID: <1a000e76-4fbf-9d02-7dfb-100b510ccc99@real-time.com> Issue was tracked and closed in https://sourceforge.net/p/crossfire/bugs/945/ Metaserver code has been patched to correct the discovered issues with Metaserver listing.