[CF-Devel] Re: [Crossfire-cvs] CVS: crossfire/common item.c,1.15,1.16 treasure.c,1.9,1.10

[Mark Wedel]

 Just as a note:

 What the code below does is hides the face of a potion until it is identfied. 
In this way, when you find a potion, you don't instantly know its a strength
potion by the face it has.

 Now this feature may not be a real big deal - after all, the potions could
still be cursed, so you will still want to do a detect curse before drinking
one.  But it does mean to some extent that you may not need to identify potions
as often.

 I have looked at all the potion images, so this may not be quite as relevant as
it once before (when all the potions were very distinct in appearance, so a
potion of strenght had a very unique appearance that nothing else was close to. 
If thats no longer the case (ie, just looking at a potion face can't tell you
what it is), this may not be as big a deal.

 And even if that is not the case, this may not be that big a deal.  But I
thought I'd at least bring it up to the developers what this change may really
mean for additional comments.


     
     crossfire-cvs-admin at lists.sourceforge.net
     
      wrote:
>
     
     
     >
     
      Update of /cvsroot/crossfire/crossfire/common
     
     >
     
      In directory usw-pr-cvs1:/tmp/cvs-serv29322
     
     >
     
     
     >
     
      Modified Files:
     
     >
     
              item.c treasure.c
     
     >
     
      Log Message:
     
     >
     
      Make the faces of potions look better.  Required commenting out
     
     >
     
      some code is all.
     
     >
     
     
     >
     
      Index: item.c
     
     >
     
      ===================================================================
     
     >
     
      RCS file: /cvsroot/crossfire/crossfire/common/item.c,v
     
     >
     
      retrieving revision 1.15
     
     >
     
      retrieving revision 1.16
     
     >
     
      diff -C2 -r1.15 -r1.16
     
     >
     
      *** item.c      2001/04/04 06:52:31     1.15
     
     >
     
      --- item.c      2001/04/21 01:22:43     1.16
     
     >
     
      ***************
     
     >
     
      *** 963,967 ****
     
     >
     
     
     >
     
          if (op->type == POTION && op->arch != (archetype *) NULL) {
     
     >
     
      !       op->face = op->arch->clone.face;
     
     >
     
              free_string(op->name);
     
     >
     
              op->name = add_refcount(op->arch->clone.name);
     
     >
     
      --- 963,967 ----
     
     >
     
     
     >
     
          if (op->type == POTION && op->arch != (archetype *) NULL) {
     
     >
     
      !     /*op->face = op->arch->clone.face; */
     
     >
     
              free_string(op->name);
     
     >
     
              op->name = add_refcount(op->arch->clone.name);
     
     >
     
     
     >
     
      Index: treasure.c
     
     >
     
      ===================================================================
     
     >
     
      RCS file: /cvsroot/crossfire/crossfire/common/treasure.c,v
     
     >
     
      retrieving revision 1.9
     
     >
     
      retrieving revision 1.10
     
     >
     
      diff -C2 -r1.9 -r1.10
     
     >
     
      *** treasure.c  2001/03/28 06:37:48     1.9
     
     >
     
      --- treasure.c  2001/04/21 01:22:43     1.10
     
     >
     
      ***************
     
     >
     
      *** 859,863 ****
     
     >
     
            }
     
     >
     
          if (op->type == POTION && special_potion(op)) {
     
     >
     
      !     op->face = potion_face;
     
     >
     
            free_string(op->name);
     
     >
     
            op->name = add_string("potion");
     
     >
     
      --- 859,863 ----
     
     >
     
            }
     
     >
     
          if (op->type == POTION && special_potion(op)) {
     
     >
     
      !     /*if(op->face==blank_face) op->face = potion_face;*/
     
     >
     
            free_string(op->name);
     
     >
     
            op->name = add_string("potion");
     
     >
     
     
     >
     
      _______________________________________________
     
     >
     
      Crossfire-cvs mailing list
     
     >
     
     
      Crossfire-cvs at lists.sourceforge.net
      
      
     >
     
     
      http://lists.sourceforge.net/lists/listinfo/crossfire-cvs