[CF-Devel] Bug in install-script of crossclient

[Klaus Elsbernd]

Hello
I found a bug in the install-script
utils/install-sh
on Solaris 8 with version crossfire-client-0.96.0
make install
calls
utils//install-sh -c gcfclient cfclient cfsndserv /tools/games/bin
wich only copies gcfclient to /tools/games/bin
cfclient and cfsndserv won't be updated.

here is a trace
0 
     
     root at gate-2000
     
     : sh -x utils//install-sh -c gcfclient cfclient cfsndserv 
/tools/games/bin
doit=
mvprog=mv
cpprog=cp
chmodprog=chmod
chownprog=chown
chgrpprog=chgrp
stripprog=strip
rmprog=rm
mkdirprog=mkdir
transformbasename=
transform_arg=
instcmd=mv
chmodcmd=chmod 0755
chowncmd=
chgrpcmd=
stripcmd=
rmcmd=rm -f
mvcmd=mv
src=
dst=
dir_arg=
+ [ x-c != x ] 
instcmd=cp
+ shift 
+ continue 
+ [ xgcfclient != x ] 
+ [ x = x ] 
src=gcfclient
+ shift 
+ continue 
+ [ xcfclient != x ] 
+ [ xgcfclient = x ] 
+ : 
dst=cfclient
+ shift 
+ continue 
+ [ xcfsndserv != x ] 
+ [ xgcfclient = x ] 
+ : 
dst=cfsndserv
+ shift 
+ continue 
+ [ x/tools/games/bin != x ] 
+ [ xgcfclient = x ] 
+ : 
dst=/tools/games/bin
+ shift 
+ continue 
+ [ x != x ] 
+ [ xgcfclient = x ] 
+ true 
+ [ x != x ] 
+ [ -f gcfclient -o -d gcfclient ] 
+ true 
+ [ x/tools/games/bin = x ] 
+ true 
+ [ -d /tools/games/bin ] 
+ basename gcfclient 
dst=/tools/games/bin/gcfclient
+ sed -e s,[^/]*$,,;s,/$,,;s,^$,., 
+ echo /tools/games/bin/gcfclient 
dstdir=/tools/games/bin
+ [ ! -d /tools/games/bin ] 
+ [ x != x ] 
+ [ x = x ] 
+ basename /tools/games/bin/gcfclient 
dstfile=gcfclient
+ [ xgcfclient = x ] 
+ true 
dsttmp=/tools/games/bin/#inst.2409#
+ cp gcfclient /tools/games/bin/#inst.2409# 
+ trap rm -f /tools/games/bin/#inst.2409# 0 
+ [ x != x ] 
+ true 
+ [ x != x ] 
+ true 
+ [ x != x ] 
+ true 
+ [ xchmod 0755 != x ] 
+ chmod 0755 /tools/games/bin/#inst.2409# 
+ rm -f -f /tools/games/bin/gcfclient 
+ mv /tools/games/bin/#inst.2409# /tools/games/bin/gcfclient 
+ exit 0 
+ rm -f /tools/games/bin/#inst.2409# 

The script seems to handle only one source-file. I would suggest to
write a for-command in the makefile arround the files to be installed.

Bis dann
Klaus

-- 
"Sure, vi is user friendly.
 It's just particular about who it makes friends with." ;-) 
                                      _________________________
Klaus Elsbernd; System Administrator, BOFH        | 
     
     elsbernd at dfki.uni-kl.de
     
     
Deutsches Forschungsz. für Künstliche Intelligenz | DFKI GmbH, Geb. 57/285
67657 Kaiserslautern; Germany                     | Tel: (+49) 0631/205-3486