[CF-Devel] make distclean problems/cleanups

Nils Lohner lohner at debian.org
Tue Jul 31 11:56:45 CDT 2001


I was trying to generate a patch and ran into problems.  I'll do this
step by step, because there's a lot of cleaning to be done.

Here's the first test.  

/sup/build/crossfire > gtar xvjf ../src/games/crossfire-1.0.0.tar.bz2
/sup/build/crossfire > mv crossfire-1.0.0 crossfire-1.0.0.orig
/sup/build/crossfire > gtar xvjf ../src/games/crossfire-1.0.0.tar.bz2
/sup/build/crossfire > cd crossfire-1.0.0
/sup/build/crossfire/crossfire-1.0.0 > ./configure
/sup/build/crossfire/crossfire-1.0.0 > make distclean
/sup/build/crossfire/crossfire-1.0.0 > cd ..
/sup/build/crossfire > diff -ruN crossfire-1.0.0 crossfire-1.0.0.orig > cfdiffs

Theoretically this diff should be minimal, but it's not.
/sup/build/crossfire > wc diffs.distclean 
    380    1633   11736 diffs.distclean


- remove crossfire-1.0.0/doc/spell-docs/Makefile
...there's a Makefile.in there and make distclean removes it.


- other removed files:
--- crossfire-1.0.0/lib/checkarch.pl    Tue Jul 31 18:30:42 2001
--- crossfire-1.0.0/utils/crossloop     Tue Jul 31 18:30:42 2001
--- crossfire-1.0.0/utils/crossloop.pl  Tue Jul 31 18:30:43 2001
--- crossfire-1.0.0/utils/metaserver.pl Tue Jul 31 18:30:43 2001
... I don't know if distclean should delete these or not.  SOmeone needs
to look at this.


- What's left:
--- crossfire-1.0.0/lib/collect.pl      Tue Jul 31 18:30:42 2001
--- crossfire-1.0.0/lib/xpmtopix.pl     Tue Jul 31 18:30:41 2001
--- crossfire-1.0.0/utils/add_throw.perl        Tue Jul 31 18:30:42 2001
...three files with the following difference:
-#!/sup/bin/perl
+#!/usr/bin/perl

This I can live with; they're easy to filter out. Next, I'll do the same
thing with a build.  I already saw that 'tags' files and '*~' backup
files are not removed by a 'make distclean'.  They should be.

Please take care of these changes, as they'll make supplying patches
much easier (so you'll get more of them :)

Thanks,
Nils.



    
    


More information about the crossfire mailing list