[CF-Devel] 32k patch to propose

[Mark Wedel]

Benjamin `Quisar' Lerman wrote:
>
     
     
     >
     
       Hi all.
     
     >
     
     
     >
     
       I've got a patch to propose there : 
      
      http://www.ambre.net/crossfire/patch_vpath
      
      
     >
     
     
     >
     
       It basically do 2 things :
     
     
 This is why I really like patches that are split up by what they do, and not
patches that combine several things.  notes below:

>
     
     
     >
     
       1) I modify the makefiles so it is possible to compile crossfire outside
     
     >
     
      the source tree (I hate to have the .o on my source tree ;oD )
     
     
 From looking over it, I have no problem with that aspect of the patch.  I
believe some work was done a while ago to do the same thing.
>
     
     
     >
     
       2) I modify the way logfile is handled. On my computers the logs where
     
     >
     
      always empty. So I just removed logfile, and made that stderr is
     
     >
     
      redirected to the logfile in Daemon mode. Then I made stderr unbuffered
     
     >
     
      and changed all the print to logfile to print to stderr.
     
     
 I really fail to see why this is needed.  It seems like this is a very big
patch for something that can be fixed in a much easier way (if in fact broken -
it works fine on my system).  I know the logfile works when I use the crossloop
scripts, and know it works when I don't.

 Just as a stylistic point, I really hate the idea of stderr potentially not
really being stderr.  I can certainly see at some point somone doing something,
and they do have a logfile set up for all the logfile output, but really do want
to put something to stderr (to assist with interactive debugging), and then get
really confused when that ends up not being what it wants.

 I do notice that the -log option did not work.  But with about 15 lines of
code, I've made it so that it now does.  IMO, this is much more preferable than
several hundred lines of code.

 I appreciate the work you are doing here.  But as a new developer, you may want
to send out some of your proposed changes before you do them and see if any of
the experienced developers can give you ideas on how to more efficiently make
the changes.


>
     
     
     >
     
      --
     
     >
     
       Benjamin `Quisar' Lerman
     
     >
     
     
      quisar at quisar.ambre.net
      
      
      http://www.ambre.net/quisar
      
      
     >
     
       "Si les yeux pouvaient tuer et enfanter, les rues seraient pleines de cadavres
     
     >
     
      et de femmes grosses." Valery
     
     >
     
      _______________________________________________
     
     >
     
      crossfire-devel mailing list
     
     >
     
     
      crossfire-devel at lists.real-time.com
      
      
     >
     
     
      https://mailman.real-time.com/mailman/listinfo/crossfire-devel