[CF-Devel] client issues

[Mark Wedel]

Preston Crow wrote:
>
     
      Pick up a bunch of unidentified arrows.  Get rid of all but one stack, so
     
     >
     
      you know they're all the same.  Drop one arrow.  Move to another square.
     
     >
     
      Apply the bowyer skill to identify the one in your inventory.  Move over
     
     >
     
      and pick up the other arrow.  Identify it with your bowyer skill.  You'll
     
     >
     
      see no change in your inventory, but if you do a dropall, you'll see that
     
     >
     
      they did merge, as one is left in your inventory.
     
     >
     
     
     >
     
      I guess that makes it a server issue.
     
     
 Thanks for the detailed way to reproduce this.  I will look at this further,
and no doubt there is an error in the drop code someplace.

 As a note, I looked at the identification code, and that code there will not
merge items.  So if for example you have 5 identified arrows and 5 arrows of the
same type in your inventory that are not identified and you identify those, you
will now have 2 stacks of 5 arrows each.  But when you drop them, they will
merge at that point.

 The way the identification code is currently written, this is actually a good
thing, as it does not otherwise preserve the next object buffers, and if objects
got merged, it would likely create various bugs/crashes.