[CF-Devel] <no subject>

[Mark Wedel]

Tolga Dalman wrote:

>
     
      hello, 
     
     >
     
     
     >
     
      i've just recognized a small cosmetic error in crossfire 1.2.
     
     >
     
     
     >
     
      socket/init.c [line 235]:
     
     >
     
      if(setsockopt(init_sockets[0].fd,SOL_SOCKET,SO_REUSEADDR, &tmp, sizeof(&tmp))) {
     
     >
     
     
     >
     
      the last argument should be sizeof(tmp). actually this doesn't matter right
     
     >
     
      now, since both sizes are equal on most (all?) systems.
     
     

  actually, they will be different in most cases, as tmp is declared a 'char', 
which would be one byte, and the pointer size is typicall 4 (or 8 on 64 bit 
systems) bytes.

  Apparantly doesn't make much difference in operation however.