[CF-Devel] alchemy experience bug(s?)

[Johnny Shelley]

Playing around w/ alchemy lately it seems that the experience for it has
increased dramatically, perhaps a bit too much. Casting simple formulae
twice was enough to go from 78->79 on the terribly evil metalforge
experience scale.

Even worse, theres an overflow in alchemy.c that can turn experience
from successful castings into a negative integer. At line 172:

                int amount = numb*numb*calc_skill_exp(caster,item);

Using an unsigned int for amount would at least keep this from taking
experience away from a character who has just been wildly successful,
although I'm not sure thats the best approach.

johnny

PGP Public Key available from:
     
     http://www.keyserver.net:11371/pks/lookup?op=get&search=0x17BF1DD3