[CF-Devel] patch: gcc 3.3 infinite loop fixed

[crossfire-devel at archives.real-time.com]

Bernd Edler wrote:
>
     
      After a session with ddd, CFLAGS="-g -O1 -Wall -W -pedantic"
     
     >
     
      and even valgrind, i found a lot of minor stuff, and
     
     >
     
      finally the real problem. :)
     
     >
     
     
     >
     
      Summary by file:
     
     >
     
     
     >
     
      common/item.c
     
     >
     
      The vital fix. Wrong buffer size was used.
     
     >
     
     
     >
     
      common/object.c
     
     >
     
      reading uninitialized value (valgrind)
     
     >
     
     
     >
     
      include/define.h
     
     >
     
      typo in function safe_strncpy,
     
     >
     
      trailing comma in enum (pedantic)
     
     >
     
     
     >
     
      include/global.h
     
     >
     
      c++ style comments
     
     >
     
     
     >
     
      include/player.h
     
     >
     
      trailing comma in enum (pedantic)
     
     >
     
     
     >
     
      socket/init.c
     
     >
     
      reading uninitialized value (valgrind)
     
     >
     
     
     >
     
      Bernd Edler
     
     
  Looks fine.  My only change would be to use memset or the like to clear out 
ns->inbuf.buf[] and not a for loop.


>
     
     
     >
     
     
     

_______________________________________________
crossfire-devel mailing list
     
     crossfire-devel at lists.real-time.com
     
     
     https://mailman.real-time.com/mailman/listinfo/crossfire-devel