[CF-Devel] random map patch

Tue Jun 15 02:25:35 CDT 2004

Todd Mitchell wrote:
>

      This patch adds a setting for random maps (put no_return_final_map 1 in

     >

      the mesg text for the random map entrance) an override on putting a

     >

      return exit on a final map.  This is useful if you want different random

     >

      maps to point to the same final map. The default behaviour is to place a

     >

      return exit on the final map. This override setting should only be used

     >

      on purpose and the final map must have an alternate exit!

     >

      The patch also adds the map level to the random map sign for players to

     >

      evaluate if they should be attempting the map.  I know level is a loaded

     >

      term when dealing with random maps but so much relies on the style maps

     >

      and it is still a bit useful to post IMHO.

     >

     >

      Ideas for more work in this area 

     >

      - a way to have the map difficulty be based on the player level, this

     >

      would make the random maps somewhat more reusable.

  That patch fundamentally looks ok.  But as a stylistic point, I generally 
don't like variable names to be in negative notation (no_...)  I'd prefer the 
positive form be used (return_final_map), and as necessary, have that default to 
1, and only if the map has something like 'return_final_map 0' turn it off.

  This just makes the code a littler when you see things like
  if (!no_return_final_map)

   It also makes it easier to reuse variables (if for example at some point, 
someone had the idea to have other meanings, the meaning still remains clear for 
more than just true/false values.

_______________________________________________
crossfire-devel mailing list

     crossfire-devel at lists.real-time.com

     https://mailman.real-time.com/mailman/listinfo/crossfire-devel