ATTN. DEVS, SERIOUS BUG (Re: [CF-Devel] Archetypes, New maps, Idease?)

crossfire-devel at archives.real-time.com crossfire-devel at archives.real-time.com
Fri Oct 1 09:26:53 CDT 2004


Congratulations, you found a legitimate - and possibly dangerous
- bug in the server :-/

what is your libc and locale?  I have glibc 2.3.4 (20040808) and
lalo:~SRC/crossfire/server/=build/server> locale
LANG=
LC_CTYPE=pt_BR
LC_NUMERIC="POSIX"
LC_TIME="POSIX"
LC_COLLATE="POSIX"
LC_MONETARY="POSIX"
LC_MESSAGES="POSIX"
LC_PAPER="POSIX"
LC_NAME="POSIX"
LC_ADDRESS="POSIX"
LC_TELEPHONE="POSIX"
LC_MEASUREMENT="POSIX"
LC_IDENTIFICATION="POSIX"
LC_ALL=


The culprit is that, at line 118 of treasure.c, isspace() is
skipping over the \0 that should signal end of string.  So, a
line in the treasures file consisting of only whitespace (which
your file does have) crashes the server.

I'd submit a patch, but I'm still pondering on the right fix.

[]s,
                                               |alo
                                               +----
--
            Those who trade freedom for security
               lose both and deserve neither.
--
     
     http://www.laranja.org/
     
                     mailto:
     
     lalo at laranja.org
     
     
 pgp key: 
     
     http://garfield.laranja.org/~lalo/gpgkey-signed.asc
     
     

GNU: never give up freedom                 
     
     http://www.gnu.org/
     
     

_______________________________________________
crossfire-devel mailing list
     
     crossfire-devel at lists.real-time.com
     
     
     https://mailman.real-time.com/mailman/listinfo/crossfire-devel
     
     
    


More information about the crossfire mailing list