[crossfire] Re: [Crossfire-cvs] CVS commit: client

[Mark Wedel]

Nicolas Weeger wrote:
>>
     
      Modified Files:
     
     >>
     
          client: CHANGES
     
     >>
     
          client/common: client-types.h commands.c misc.c newsocket.c player.c
     
     >>
     
              proto.h
     
     >>
     
          client/gtk: gx11.c keys.c
     
     >>
     
          client/gtk/win32: config.h
     
     >>
     
     
     >>
     
      Log Message:
     
     >>
     
      Fix a buffer overflow in unbind output. Make strings const when possible
     
     >
     
     
     >
     
     
     >
     
      Just committed those modifications. Strings are now const when possible 
     
     >
     
      (specially when getting values from GTK widgets).
     
     >
     
      Since i changed some files in common, i may have broken gnome/x11 
     
     >
     
      clients (are they still in use??).
     
     
  x11 client is still used by some people.

  Actually, I got curious and just ran a count from the metalforge server:

      13 CS: connection from client of type < >
      20 CS: connection from client of type < Crossfire Bot>
      36 CS: connection from client of type < GTK Unix Client >
       1 CS: connection from client of type < GTK Unix Client 1.4.0>
      14 CS: connection from client of type < GTK Unix Client 1.5.0>
       2 CS: connection from client of type < GTK Unix Client 1.6.0>
     101 CS: connection from client of type < GTK Unix Client 1.7.0>
       3 CS: connection from client of type < GTK Win32 Client 1.6.1>
      74 CS: connection from client of type < GTK Win32 Client 1.7.0>
       1 CS: connection from client of type < Perl Bot>
       1 CS: connection from client of type < PyClient 0.1>
      26 CS: connection from client of type < X11 Unix Client >
       3 CS: connection from client of type < X11 Unix Client 1.6.1>
      44 CS: connection from client of type < X11 Unix Client 1.7.0>

  Note that this only logs connections, so one person that 
disconnects/reconnects a lot could skew the number.

  But it is certainly safe to say that at least a few people use the X11 
client.