[CF-Devel] Re: [Crossfire-cvs] CVS commit: crossfire

[crossfire-devel at archives.real-time.com]

     crossfire-cvs-admin at lists.sourceforge.net
     
      wrote:
>
     
      Index: crossfire/server/main.c
     
     [...]
>
     
     !     if (!(QUERY_FLAG(pl->ob,FLAG_WIZ) && pl->ob->contr->hidden) &&
     
     >
     
     !         (pl!=NULL && draw_exit)) new_draw_info(NDI_UNIQUE | NDI_ALL | NDI_DK_ORANGE, 5, NULL, buf);
     
     
This code seems rather "wrong" to me: all statements within the function
leave() (which is the enclosing function of this code fragment) check
"pl != NULL" before accessing pl. Therefore this statement will crash if
a NULL value would be passed. (On the other hand, I did not find any
caller that could possibly pass such a NULL value...)

_______________________________________________
crossfire-devel mailing list
     
     crossfire-devel at lists.real-time.com
     
     
     https://mailman.real-time.com/mailman/listinfo/crossfire-devel