[crossfire] gcfclient info window text trimming crash.

[Mark Wedel]

Brendan Lally wrote:
> gcfclient can be made to crash reliably with the "Trims text in the
> information window" option set when compiled against 1.2.10.
> 
> This was reported on #crossfire, and I have been able to reproduce it
> reliably (grab lots of items, and repeatedly pickup and drop them).
> 
> Since this appears to be a GTK bug, which is presumably not present
> under gtk2, I therefore suggest that the patch which is connected to
> bug #1423605 - https://sourceforge.net/tracker/index.php?func=detail&aid=1423605&group_id=13833&atid=113833
> as a work around.
> 
> Basically I am adding
> #if GTK_MAJOR_VERSION > 1
> ...
> #endif
> around the trimming code. (although there are also a couple of minor
> cleanups too).
> 
> The reason I am posting this here, is to ask if there is a better way
> to do this (it works fine for me running gtk 1.2, but does it break
> windows builds)?

  It is a little unclear what exactly the GTK_MAJOR_VERSION check is around.

  Does this mean that info trimming is completely disabled with version 1 of 
gtk?  If so, I'd sort of say, what is the point - that is why there is a config 
option.

  Although, I suppose if that is the case, there isn't a big reason for a config 
option.

> 
> Presumably 2.0 will compile gcfclient against gtk2, so there will be
> no further issue with this; however since this doesn't seem likely to
> be the case with 1.9 some way to stop it crashing seems to be in
> order.

  Are you sure version 2.0+ of GTK fixes the problem?  IIRC when doing the gtk2 
client, there is a new widget for text stuff for gtk2, and the gtk2 docs 
specifically say don't use the old widget if at all possibly because it is 
severely broken.

  That said, it could be that that option get removed from the config page - if 
people want to muck with their config file, fair enough, but they are doing that 
at their own risk.  IIRC, the config page specifically says it may cause crashes 
if you use that option.