[crossfire] broken configure on opensolaris

[Mark Wedel]

  The following revision has broken the ability to build crossfire on 
opensolaris - now I admit that is probably a pretty small audience (me), but I 
also don't know if this might cause issues for other users if this is a minimum 
required version of aclocal/automake/autoconf for example (if this change was 
only done/tested on a system which had the latest versions of those utilities, 
that might also be an incomplete test).

  But I'm not sure if the error is in the actual changes/minimum versions, or if 
maybe something in my toolchain itself is broken.

  I suspect the issue is that my system has libtool 1.5.22 installed - fairly 
old, but I would guess that if libtool 2.x is needed, that should probably be 
noted someplace (I don't know if autogen.sh should perhaps be modified to do 
minimum version checking if needed?)  I think we have run into this in the past 
with needing minimum version of automake also.

  I'm going to try and download latest libtool and see if that works (I suspect 
it will).  But I guess at the same time, it would have saved me a bunch of time 
if autogen (or something) just spit out "you need > 2.0 of libtool" type of thing.



  The revision in question:
---
r13979 | anmaster | 2010-10-09 14:14:22 -0700 (Sat, 09 Oct 2010) | 10 lines

Do not make symbols globally visible by default on *nix (when supported),
on Windows this is always the case. To prevent hidden errors (since most
developers seem to test on *nix), use -fvisibility=hidden when GCC is used
and make the MODULEAPI and CF_PLUGIN macros use __attribute__ to mark those
as visible. This will not break on any compiler not supporting this, but will
prevent future hidden errors of this type.

A further advantage with this is that it reduces risk of symbol name collision
between various dynamic objects.
---

  (If I change the macros and configure.ac to the version prior to that, all 
works fine).  Below is output of running autogen.sh:

[hugin:/export/home/crossfire/SVN/server/trunk] (54) % sh autogen.sh
You should update your `aclocal.m4' by running aclocal.
Putting files in AC_CONFIG_AUX_DIR, `utils'.
/usr/share/aclocal/aalib.m4:12: warning: underquoted definition of AM_PATH_AALIB
/usr/share/aclocal/aalib.m4:12:   run info '(automake)Extending aclocal'
/usr/share/aclocal/aalib.m4:12:   or see 
http://sources.redhat.com/automake/automake.html#Extending-aclocal
configure.ac:17: warning: AC_CACHE_VAL(lt_prog_compiler_pic_works, ...): 
suspicious cache-id, must contain _cv_ to be cached
../../lib/autoconf/general.m4:1974: AC_CACHE_VAL is expanded from...
../../lib/autoconf/general.m4:1994: AC_CACHE_CHECK is expanded from...
macros/libtool.m4:615: AC_LIBTOOL_COMPILER_OPTION is expanded from...
macros/libtool.m4:4815: AC_LIBTOOL_PROG_COMPILER_PIC is expanded from...
macros/libtool.m4:2651: _LT_AC_LANG_C_CONFIG is expanded from...
macros/libtool.m4:2650: AC_LIBTOOL_LANG_C_CONFIG is expanded from...
macros/libtool.m4:80: AC_LIBTOOL_SETUP is expanded from...
macros/libtool.m4:60: _AC_PROG_LIBTOOL is expanded from...
macros/libtool.m4:25: AC_PROG_LIBTOOL is expanded from...
configure.ac:17: the top level
configure.ac:17: warning: AC_CACHE_VAL(lt_prog_compiler_static_works, ...): 
suspicious cache-id, must contain _cv_ to be cached
macros/libtool.m4:660: AC_LIBTOOL_LINKER_OPTION is expanded from...
configure.ac:17: warning: AC_CACHE_VAL(lt_prog_compiler_pic_works_CXX, ...): 
suspicious cache-id, must contain _cv_ to be cached
macros/libtool.m4:2732: _LT_AC_LANG_CXX_CONFIG is expanded from...
macros/libtool.m4:2731: AC_LIBTOOL_LANG_CXX_CONFIG is expanded from...
macros/libtool.m4:1787: _LT_AC_TAGCONFIG is expanded from...
configure.ac:17: warning: AC_CACHE_VAL(lt_prog_compiler_static_works_CXX, ...): 
suspicious cache-id, must contain _cv_ to be cached
configure.ac:17: warning: AC_CACHE_VAL(lt_prog_compiler_pic_works_F77, ...): 
suspicious cache-id, must contain _cv_ to be cached
macros/libtool.m4:3899: _LT_AC_LANG_F77_CONFIG is expanded from...
macros/libtool.m4:3898: AC_LIBTOOL_LANG_F77_CONFIG is expanded from...
configure.ac:17: warning: AC_CACHE_VAL(lt_prog_compiler_static_works_F77, ...): 
suspicious cache-id, must contain _cv_ to be cached
configure.ac:17: warning: AC_CACHE_VAL(lt_prog_compiler_pic_works_GCJ, ...): 
suspicious cache-id, must contain _cv_ to be cached
macros/libtool.m4:4001: _LT_AC_LANG_GCJ_CONFIG is expanded from...
macros/libtool.m4:4000: AC_LIBTOOL_LANG_GCJ_CONFIG is expanded from...
configure.ac:17: warning: AC_CACHE_VAL(lt_prog_compiler_static_works_GCJ, ...): 
suspicious cache-id, must contain _cv_ to be cached
configure.ac:17: warning: AC_CACHE_VAL(lt_prog_compiler_pic_works, ...): 
suspicious cache-id, must contain _cv_ to be cached
../../lib/autoconf/general.m4:1974: AC_CACHE_VAL is expanded from...
../../lib/autoconf/general.m4:1994: AC_CACHE_CHECK is expanded from...
macros/libtool.m4:615: AC_LIBTOOL_COMPILER_OPTION is expanded from...
macros/libtool.m4:4815: AC_LIBTOOL_PROG_COMPILER_PIC is expanded from...
macros/libtool.m4:2651: _LT_AC_LANG_C_CONFIG is expanded from...
macros/libtool.m4:2650: AC_LIBTOOL_LANG_C_CONFIG is expanded from...
macros/libtool.m4:80: AC_LIBTOOL_SETUP is expanded from...
macros/libtool.m4:60: _AC_PROG_LIBTOOL is expanded from...
macros/libtool.m4:25: AC_PROG_LIBTOOL is expanded from...
configure.ac:17: the top level
configure.ac:17: warning: AC_CACHE_VAL(lt_prog_compiler_static_works, ...): 
suspicious cache-id, must contain _cv_ to be cached
macros/libtool.m4:660: AC_LIBTOOL_LINKER_OPTION is expanded from...
configure.ac:17: warning: AC_CACHE_VAL(lt_prog_compiler_pic_works_CXX, ...): 
suspicious cache-id, must contain _cv_ to be cached
macros/libtool.m4:2732: _LT_AC_LANG_CXX_CONFIG is expanded from...
macros/libtool.m4:2731: AC_LIBTOOL_LANG_CXX_CONFIG is expanded from...
macros/libtool.m4:1787: _LT_AC_TAGCONFIG is expanded from...
configure.ac:17: warning: AC_CACHE_VAL(lt_prog_compiler_static_works_CXX, ...): 
suspicious cache-id, must contain _cv_ to be cached
configure.ac:17: warning: AC_CACHE_VAL(lt_prog_compiler_pic_works_F77, ...): 
suspicious cache-id, must contain _cv_ to be cached
macros/libtool.m4:3899: _LT_AC_LANG_F77_CONFIG is expanded from...
macros/libtool.m4:3898: AC_LIBTOOL_LANG_F77_CONFIG is expanded from...
configure.ac:17: warning: AC_CACHE_VAL(lt_prog_compiler_static_works_F77, ...): 
suspicious cache-id, must contain _cv_ to be cached
configure.ac:17: warning: AC_CACHE_VAL(lt_prog_compiler_pic_works_GCJ, ...): 
suspicious cache-id, must contain _cv_ to be cached
macros/libtool.m4:4001: _LT_AC_LANG_GCJ_CONFIG is expanded from...
macros/libtool.m4:4000: AC_LIBTOOL_LANG_GCJ_CONFIG is expanded from...
configure.ac:17: warning: AC_CACHE_VAL(lt_prog_compiler_static_works_GCJ, ...): 
suspicious cache-id, must contain _cv_ to be cached
configure.ac:17: warning: AC_CACHE_VAL(lt_prog_compiler_pic_works, ...): 
suspicious cache-id, must contain _cv_ to be cached
../../lib/autoconf/general.m4:1974: AC_CACHE_VAL is expanded from...
../../lib/autoconf/general.m4:1994: AC_CACHE_CHECK is expanded from...
macros/libtool.m4:615: AC_LIBTOOL_COMPILER_OPTION is expanded from...
macros/libtool.m4:4815: AC_LIBTOOL_PROG_COMPILER_PIC is expanded from...
macros/libtool.m4:2651: _LT_AC_LANG_C_CONFIG is expanded from...
macros/libtool.m4:2650: AC_LIBTOOL_LANG_C_CONFIG is expanded from...
macros/libtool.m4:80: AC_LIBTOOL_SETUP is expanded from...
macros/libtool.m4:60: _AC_PROG_LIBTOOL is expanded from...
macros/libtool.m4:25: AC_PROG_LIBTOOL is expanded from...
configure.ac:17: the top level
configure.ac:17: warning: AC_CACHE_VAL(lt_prog_compiler_static_works, ...): 
suspicious cache-id, must contain _cv_ to be cached
macros/libtool.m4:660: AC_LIBTOOL_LINKER_OPTION is expanded from...
configure.ac:17: warning: AC_CACHE_VAL(lt_prog_compiler_pic_works_CXX, ...): 
suspicious cache-id, must contain _cv_ to be cached
macros/libtool.m4:2732: _LT_AC_LANG_CXX_CONFIG is expanded from...
macros/libtool.m4:2731: AC_LIBTOOL_LANG_CXX_CONFIG is expanded from...
macros/libtool.m4:1787: _LT_AC_TAGCONFIG is expanded from...
configure.ac:17: warning: AC_CACHE_VAL(lt_prog_compiler_static_works_CXX, ...): 
suspicious cache-id, must contain _cv_ to be cached
configure.ac:17: warning: AC_CACHE_VAL(lt_prog_compiler_pic_works_F77, ...): 
suspicious cache-id, must contain _cv_ to be cached
macros/libtool.m4:3899: _LT_AC_LANG_F77_CONFIG is expanded from...
macros/libtool.m4:3898: AC_LIBTOOL_LANG_F77_CONFIG is expanded from...
configure.ac:17: warning: AC_CACHE_VAL(lt_prog_compiler_static_works_F77, ...): 
suspicious cache-id, must contain _cv_ to be cached
configure.ac:17: warning: AC_CACHE_VAL(lt_prog_compiler_pic_works_GCJ, ...): 
suspicious cache-id, must contain _cv_ to be cached
macros/libtool.m4:4001: _LT_AC_LANG_GCJ_CONFIG is expanded from...
macros/libtool.m4:4000: AC_LIBTOOL_LANG_GCJ_CONFIG is expanded from...
configure.ac:17: warning: AC_CACHE_VAL(lt_prog_compiler_static_works_GCJ, ...): 
suspicious cache-id, must contain _cv_ to be cached
configure.ac:17: warning: AC_CACHE_VAL(lt_prog_compiler_pic_works, ...): 
suspicious cache-id, must contain _cv_ to be cached
../../lib/autoconf/general.m4:1974: AC_CACHE_VAL is expanded from...
../../lib/autoconf/general.m4:1994: AC_CACHE_CHECK is expanded from...
macros/libtool.m4:615: AC_LIBTOOL_COMPILER_OPTION is expanded from...
macros/libtool.m4:4815: AC_LIBTOOL_PROG_COMPILER_PIC is expanded from...
macros/libtool.m4:2651: _LT_AC_LANG_C_CONFIG is expanded from...
macros/libtool.m4:2650: AC_LIBTOOL_LANG_C_CONFIG is expanded from...
macros/libtool.m4:80: AC_LIBTOOL_SETUP is expanded from...
macros/libtool.m4:60: _AC_PROG_LIBTOOL is expanded from...
macros/libtool.m4:25: AC_PROG_LIBTOOL is expanded from...
configure.ac:17: the top level
configure.ac:17: warning: AC_CACHE_VAL(lt_prog_compiler_static_works, ...): 
suspicious cache-id, must contain _cv_ to be cached
macros/libtool.m4:660: AC_LIBTOOL_LINKER_OPTION is expanded from...
configure.ac:17: warning: AC_CACHE_VAL(lt_prog_compiler_pic_works_CXX, ...): 
suspicious cache-id, must contain _cv_ to be cached
macros/libtool.m4:2732: _LT_AC_LANG_CXX_CONFIG is expanded from...
macros/libtool.m4:2731: AC_LIBTOOL_LANG_CXX_CONFIG is expanded from...
macros/libtool.m4:1787: _LT_AC_TAGCONFIG is expanded from...
configure.ac:17: warning: AC_CACHE_VAL(lt_prog_compiler_static_works_CXX, ...): 
suspicious cache-id, must contain _cv_ to be cached
configure.ac:17: warning: AC_CACHE_VAL(lt_prog_compiler_pic_works_F77, ...): 
suspicious cache-id, must contain _cv_ to be cached
macros/libtool.m4:3899: _LT_AC_LANG_F77_CONFIG is expanded from...
macros/libtool.m4:3898: AC_LIBTOOL_LANG_F77_CONFIG is expanded from...
configure.ac:17: warning: AC_CACHE_VAL(lt_prog_compiler_static_works_F77, ...): 
suspicious cache-id, must contain _cv_ to be cached
configure.ac:17: warning: AC_CACHE_VAL(lt_prog_compiler_pic_works_GCJ, ...): 
suspicious cache-id, must contain _cv_ to be cached
macros/libtool.m4:4001: _LT_AC_LANG_GCJ_CONFIG is expanded from...
macros/libtool.m4:4000: AC_LIBTOOL_LANG_GCJ_CONFIG is expanded from...
configure.ac:17: warning: AC_CACHE_VAL(lt_prog_compiler_static_works_GCJ, ...): 
suspicious cache-id, must contain _cv_ to be cached
checking for a BSD-compatible install... /usr/bin/ginstall -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... utils/install-sh -c -d
checking for gawk... gawk
checking whether gmake -j4 sets $(MAKE)... yes
./configure: line 2623: syntax error at line 2627: `(' unexpected

Line 2623 of configure on my system is:
else
   enable_shared=yes
fi


     _LT_DECL(build_libtool_libs, enable_shared, 0,
         Whether or not to build shared libraries)


# Check whether --enable-static was given.
if test "${enable_static+set}" = set; then