[crossfire] Player creation bug

[Tolga Dalman]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

currently, the player creation in crossfire 1.60 is broken.
You can reproduce it by doing the following with the
crossfire-client 1.60:
- - create new character: fire hatchling/monk
- - maximize str, dex and con
- - set remaining stats so that they are 1 in total
- - distribute the remaining points to pow

This will fail, because the stats are checked after applying the
race (but not the class). The attached patch fixes this issue.

Being on this topic, I have some suggestions for the crossfire-client.
I think it is already pretty good, however for a normal user like
me it is quite difficult to create a character in a sane way.
So I suggest:
1. add descriptions for stats (e.g. tooltips).
2. make the stat number field read-only (this feature is actually not useful,
   but rather confusing and error-prone).
3. when selecting a race or class automatically update the stats to the required
   minimum values. Also, these values should become constraints, i.e. pushing
   the '-' should not yield in stats lower 1.
4. disallow negative unspent stat points. This should be a simple check in the
   '+' buttons.
5. "Choose starting map" should be replaced by the actual drop-down menu with
   "Scorn" as default value.

I hope these suggestions are helpful :)

Thanks and best regards
Tolga Dalman
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJNV8TcAAoJEATLYSm2cxP9t9QH/jVFZTnVNZJUOwLpjp7nNhQO
j9oh9KJaH2Ur1bhgvUVsuUw0OicK0vsiAOfpT5v6WOer0ORsE7Sl+vH6M85u4fs5
mJZzAGcCI9/G7qbi/AjDdxuwuXV8PRxOP1SAOKLCbjVZW7H1PfJdszGW64Gv51+u
Ah07nVGoNHC/w77I2rDzLiZ3jQBXOXybjY36OyOF3e2drJf8v9p/5/YMnCmBqi5l
GCCyavUwFOMwwIlLMaxagdRCbK3brqRgLWgkOchI6w2NAsOrY+JdRb4PtR2OWOnl
psjiHxuHIcc5vt/I3m27885pL9geSp0ysEAbeRmXur/9mXOgEtJvY5ROLnjXiEQ=
=Rtb2
-----END PGP SIGNATURE-----
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: player.c.diff
URL: <http://mailman.metalforge.org/pipermail/crossfire/attachments/20110213/787314d8/attachment.ksh>