[crossfire] Checking and ATM breakage

[meflin at meflin.net]

We should get together to check the code on invidious.

The original author worked on invidious and then disapeared. There could be more up 
to date versions to base the work on.

Meflin

On Tuesday, July 30, 2013 11:16:10 PM Kevin Zheng wrote:
> Hi there,
> 
> I'm working on some cleanups to the banking-related code in Crossfire,
> specifically in 'python/IPO/banksay.py' and 'CFBank.py'. I've noticed
> that certain features (i.e. ATMs and checking) either are unstable or
> flatly refuse to work.
> 
> It seems that 'banksay.py' tries to create a checkbook based on a
> template item in a hidden location on the bank map. In modern versions
> of the bank, this hidden items has been removed; in addition, so many
> different branches have opened that this is no longer a viable solution.
> I'm planning to hard-code the checkbook creation code in the bank script
> itself. Does this seem to be a good idea? Also, could somebody point me
> to a revision where the template stills exists? ('svn blame' isn't
> terribly helpful)
> 
> Also, ATMs tend to steal your money unless you apply and unapply the
> deposit box twice, and sometimes that doesn't work. I propose to
> temporarily disable ATMs until I have a look at it.
> 
> I have not yet committed my changes; I'm still tying up some loose ends
> and testing that everything is stable and backwards-compatible. Those
> interested in testing my work-in-progress can find a patch attached.
> Questions, concerns, comments, and hate mail are welcome. And yes,
> everything is in bite-sized commits (I use a local Git repo).
> 
> Thanks,
> Kevin Zheng
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.metalforge.org/pipermail/crossfire/attachments/20130730/acc29d87/attachment.html>