[crossfire] [PATCH 1/2] Keybindings: multiple changes

[Arvid Brodin]

On 2013-11-03 04:41, Kevin Zheng wrote:
> Committed in r19090.
> 
> To the best of my knowledge, Crossfire doesn't have a formal patch
> review process. By the time everyone reviews it, bit rot will have
> already set in. Best to commit it now and fix issues later if needed.

Ok.


> On 11/02/2013 18:24, Arvid Brodin wrote:
>> * Show all keybindings (incl default ones) in both 'unbind' and the keybindings
>>   dialog. (Should reduce confusion for new users.)
> 
> I almost want to say that I miss the old behavior. If feasible, I'd
> really like to see a "show non-default bindings only" checkbox.

I see what you mean - suddenly there's a lot of "noise" in the keybindings
dialog. What I did was to remove all bindings that I don't use, and it feels 
OK now. Perhaps that'll work for you as well? If you try it and still hate
it, tell me and I'll see what I can do. :)

I will also submit a cleaned-up version of the common/def-keys file. There 
are some obvious clean-ups and some "maybe": 

- 3 bindings of 'a' to "apply" (to handle different shift state and modifier 
  states). Replace with a single binding of 'a' with "Any" flag.

- 2 of 'e' to examine (shift state). Replace with single binding of 'e'.

- What's the difference between the "take" and the "pickup" commands? (',', 
  '@')

- How often do we get new players who use Sun Type 4 Keyboards? Perhaps these
  could go? (17 bindings.)

- Is there a difference between "rotateshoottype -" and "rotateshoottype -1"?
  Also needs modifier flags cleanup (A/N/NF).


These I don't really know about:

- I've never seen the "Nethack-Style" key layout before. Also, they don't seem
  to work in conjunction with the Fire modifier (only N and R). Does the fact
  that that bug has never been fixed mean they aren't used at all, perhaps? Or
  do people just fix that when they start to play?

- Arrow keys... I *really* like the feature of command history and the prevkey/
  nextkey that is available. But these are not bound by default, so perhaps they
  aren't used as much as they could be. On the other hand, using the arrow keys
  for this (and not for north/south etc) requires an immidiate help text whenever
  a new character is started, to explain how to move.



-- 
Arvid