[crossfire] [PATCH 1/2] Keybindings: multiple changes

[Kevin Zheng]

On 11/03/2013 08:50, Arvid Brodin wrote:
> I see what you mean - suddenly there's a lot of "noise" in the keybindings
> dialog. What I did was to remove all bindings that I don't use, and it feels 
> OK now. Perhaps that'll work for you as well? If you try it and still hate
> it, tell me and I'll see what I can do. :)

It's not too bad. Since most of my personal key bindings are applied
with the ALT key, I can just sort the list by modifier.

> I will also submit a cleaned-up version of the common/def-keys file. There 
> are some obvious clean-ups and some "maybe": 
> 
> - 3 bindings of 'a' to "apply" (to handle different shift state and modifier 
>   states). Replace with a single binding of 'a' with "Any" flag.

In hindsight, there are some issues with setting the directional keys
with the "Any" flag. I usually bind ALT-B to 'cast burning hands', but
it conflicts with the 'Any' definition of a NetHack-style direction key.
Perhaps the 'Normal' checkbox should come back?

> - 2 of 'e' to examine (shift state). Replace with single binding of 'e'.

There should just be one examine command, "examine." I think it should
be bound to normal and CTRL.

> - What's the difference between the "take" and the "pickup" commands? (',', 
>   '@')

The 'pickup' binding should probably go. In NetHack, '@' toggles
auto-pickup, but Crossfire's 'pickup' command requires an argument.
Perhaps it was left over from a long time ago.

> - How often do we get new players who use Sun Type 4 Keyboards? Perhaps these
>   could go? (17 bindings.)

Admittedly, not that often. Binaries aren't even being built for modern
Sun machines (with normal keyboards).

> - Is there a difference between "rotateshoottype -" and "rotateshoottype -1"?
>   Also needs modifier flags cleanup (A/N/NF).

Not exactly sure, they *seem* to do the same :p

> These I don't really know about:
> 
> - I've never seen the "Nethack-Style" key layout before. Also, they don't seem
>   to work in conjunction with the Fire modifier (only N and R). Does the fact
>   that that bug has never been fixed mean they aren't used at all, perhaps? Or
>   do people just fix that when they start to play?

I've always used NetHack style keys, and they've been working fine all
the time. After the update some interesting things are happening, which
I'm working on investigating.

> - Arrow keys... I *really* like the feature of command history and the prevkey/
>   nextkey that is available. But these are not bound by default, so perhaps they
>   aren't used as much as they could be. On the other hand, using the arrow keys
>   for this (and not for north/south etc) requires an immidiate help text whenever
>   a new character is started, to explain how to move.

Thing with Crossfire is that we don't have a "pop-up-on-your-screen"
tutorial at the beginning. And if players start by using the arrow keys
(based on intuition), they probably won't discover the other ways to
move, either.

Thanks,
Kevin Zheng