[crossfire] [PATCH] Crossfire client linking fails in trunk

Tue Aug 12 03:12:28 CDT 2014

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 08/12/2014 04:42 AM, Kevin Zheng wrote:
> On 08/11/2014 14:16, Tolga Dalman wrote:
>> Naturally, I would compile with -std=gnu99, but that's not a portable 
>> solution :)
> 
> Actually, the current `configure` script already adds "-std=gnu99" or some
> variant thereof behind your back. While getaddrinfo(3) is a POSIX 
> extension, it is still relatively portable. On Windows, this issue is taken
> care of with a few preprocessor definitions.

What configure script ?? I just did

	$ mkdir build; cd build; cmake ..; make

> It may not even be this problem at all. I need to go take a closer look at
> the code; it may be just that we're missing a header file.
> 
>> /home/tdalman/src/crossfire/client/trunk/common/client.c:497:5: warning: 
>> implicit declaration of function 'freeaddrinfo'
>> [-Wimplicit-function-declaration] freeaddrinfo(res); ^
> 
> Ditto, although I'm fairly certain this is due to a missing header.

Yes, replacing std=c99 by std=gnu99 defines the necessary POSIX extension
macros and, thus, fixes all errors.