[crossfire] [PATCH] Crossfire client linking fails in trunk

Kevin Zheng kevinz5000 at gmail.com
Wed Aug 13 15:07:03 CDT 2014


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 08/12/2014 03:12, Tolga Dalman wrote:
>> Actually, the current `configure` script already adds
>> "-std=gnu99" or some variant thereof behind your back. While
>> getaddrinfo(3) is a POSIX extension, it is still relatively
>> portable. On Windows, this issue is taken care of with a few
>> preprocessor definitions.
> 
> What configure script ?? I just did
> 
> $ mkdir build; cd build; cmake ..; make

The `configure` script from Autotools, not CMake.

> Yes, replacing std=c99 by std=gnu99 defines the necessary POSIX
> extension macros and, thus, fixes all errors.

If the code compiles correctly using "-std=gnu99", then use it. While
portability is definitely a desirable, it's probably better done along
with some other massive change (i.e. GIO networking).

Thanks,
Kevin Zheng
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBAgAGBQJT68VnAAoJEOrPD3bCLhCQLG4IAKmxxcI6c1X14iG3iGqkn0XB
7nTchsmUiDdM0wyhxxUOAjdw0GG6Hx474yR1nh1wZwQkmiVHYxQbGV7fpVrGnPXx
IouDiTBH2ZSlmfxVZVMrXhwUy3bmcaXTTZHG07jCMduQvsZZFg7pa7mm5gz9qg/3
zFegVmm/sPLLxUNR8ClqFLNEXZB1VXCmgtT8t2rCmoe7qCcnUc7Rq0Gqp0coEVt7
GoHWlsvTsawwcUTSoU5wJzv9gKwmflW0xD0wZ/hEBhxW3lpOfT2OK9fpfMdxyYly
ggYbKL2+6aqqsygg+FwvGYYGdKtCkIFEymXVyCsoZlxH4aKgOQ8Tnz/f1Ald5yo=
=jguB
-----END PGP SIGNATURE-----


More information about the crossfire mailing list