[CF-Devel] CFEditor cleaning up

[Bob Tanner]

Quoting Yann Chachkoff (
     
     yann.chachkoff at gmx.net
     
     ):
>
     
      > - new build file
     
     >
     
      >      I have removed all old Makefiles, scripts, buildfiles,
     
     >
     
      >      batch files, ... They are replaced by "build.xml" for ant
     
     >
     
      >      for building the app and small scripts for starting.
     
     >
     
      Sounds like a good idea. The previous installation scheme was too complex in 
     
     >
     
      most cases.
     
     
Hate to bring up an old thread and fresh flamewar, but I did the same thing, but
AV rejected my commit.

>
     
      > - new packages for java sources
     
     >
     
      >      According to naming conventions, I have moved the sources
     
     >
     
      >      in a source directory and to the package
     
     >
     
      >      "de.tabacha.crossfire.editor". I would have preferred
     
     >
     
      >      "com.real-time.crossfire.editor", but "-" is not allowed
     
     >
     
      >      in a package name.
     
     >
     
      Again sounds like a good idea. My only objection here would be that you used 
     
     >
     
      your personnal domain name as package name - Something more 'crossfire' would 
     
     >
     
      have been better. But I also understand the problem with the "-". Anyway, 
     
     >
     
      that new convention may help to integrate CFJavaEditor better in a complete 
     
     >
     
      Java environment.
     
     
Again, I did the same thing and AV reject the commit because the naming
convention does not work (or work well) with his IDE.

I believe I used org.crossfire.editor, yes, we don't own the crossfire.org
domain, but I thought it was the best match.

>
     
      > - Resources included in jar
     
     >
     
      >      When building the jar, the resource files (icons, help
     
     >
     
      >      files, default configuration files) are included. From
     
     >
     
      >      comments in the source code, someone has earlier tried to do
     
     >
     
      >      this and had problems. Can you check my changes, please?
     
     >
     
      Distributing the resources as a Jar archive sounds quite natural (I wonder why 
     
     >
     
      this wasn't done before with CFJavaEditor). This is again the standard way of 
     
     >
     
      doing things in the Java world, so I agree with you on that point.
     
     
This code was all in CVS at one time. Again, I believe AV didn't accept the
commits.

>
     
      > - Separating the PNG support from the CFEditor code.
     
     >
     
      >      Previously, the PNG source files were included in the
     
     >
     
      >      repository. I downloaded the newest version from sixlegs.com;
     
     >
     
      >      now it's used as a library.
     
     >
     
      There was a technical reason to supply PNG code directly with CFJavaEditor 
     
     >
     
      sources - some bugs in the original png classes prevented its direct use.
     
     >
     
      As long as those bugs are corrected in the latest version of Sixlegs PNG 
     
     >
     
      classes, I see no reason to maintain those sources in CFJavaEditor.
     
     
Yep, "fixed" this issue as well. 

-- 
Bob Tanner <
     
     tanner at real-time.com
     
     >         | Phone : (952)943-8700
     
     http://www.mn-linux.org,
     
      Minnesota, Linux | Fax   : (952)943-8500
     
     http://www.tcwug.org,
     
      Minnesota, Wireless | Coding isn't a crime. 
Fingerprint: 02E0 2734 A1A1 DBA1 0E15  623D 0036 7327 93D9 7DA3