[CF-Devel] #define's that I want to just kill outright

[Rick Tanner]

My comments are mixed within the original email...

On Wed, 13 Nov 2002, Tim Rightnour wrote:

<snip>
>
     
     
     >
     
      Unless nobody objects.. the following are going to die and become default.
     
     >
     
     
     >
     
      >>  * USE_SWAP_STATS - allows stat swapping for new characters
     
     >
     
      >>   NO_AUTO_SKILL_SWITCH: /* To be removed soon (setable by player) */
     
     
I agree, remove them.


>
     
     
     >
     
      These.. I think require some discussion:
     
     >
     
     
     >
     
      >>   WALL_CREDIT: players earn exp for killing with summon fog.
     
     >
     
      >   Didn't even realize that exists.
     
     >
     
     
     >
     
      Apparently, if you build a bulletwall, or cast summon fog.  You don't get any
     
     >
     
      exp for what it kills.  If you turn on WALL_CREDIT, you do.  I believe we
     
     >
     
      should just turn it on.. But I'd like to hear either way.  If people are really
     
     >
     
      divided on it, then I'll option it as a setting.
     
     
I agree, turn it on.  I have to admit I'm a little biased towards this
since I always had this enabled and often used bulletwalls to level up my
Magic EXP. ;)


>
     
     
     >
     
      >>  * NO_CONE_PROPOGATE - makes cone spells stop at the first monster
     
     >
     
      >   It works, I don't know if anyone uses it - makes things a lot more
     
     >
     
      > difficult for spellcasters.
     
     >
     
     
     >
     
      Does anyone want this to stay?  If not.. I say we nuke it.
     
     
I commented on this earlier - nuke it.


>
     
     
     >
     
      SECURE  is there any reason to keep this?  Is it that unreasonable that the
     
     >
     
      person who executes the server might want to change the libdir?  I think this
     
     >
     
      comes from a time when players actually played on a physical machine, owned by
     
     >
     
      someone.  I say we turn it on, and pull the ifdefs out.
     
     
Agree.


>
     
     
     >
     
      MULTIPLE_GODS - adds numerous gods to the game, with different powers
     
     >
     
      As far as I'm concerned.. this is the default now.. and should just stay that
     
     >
     
      way.
     
     
I can't even imagine playing the game without this enabled.  Make it the
default.


>
     
     
     >
     
      DUMP_SWITCHES - is there any reason NOT to compile these in?  Again, I think
     
     >
     
      this goes back to the old days.. where people shared a machine.
     
     
My vote is to leave it in (on?)


>
     
     
     >
     
      ENABLE_CHECKSUM/USE_CHECKSUM - This should either be the default, or not the
     
     >
     
      default.  I don't care which, but my gut instinct is to nuke the checksum.  If
     
     >
     
      a DM wants to run around editing his players.  let him.  If a person wants to
     
     >
     
      play at home and cheat.  let him.
     
     
I am indifferent about this, I only partly understand it. =/


>
     
      MORE_PRIEST_GIFTS- I'm pretty sure this is off by default.  Nuke it?  turn it
     
     >
     
      on?
     
     
How does this work, exactly?

Is it different then getting Thorin's Plate Mail for Mostrai followers
when they reach a certain level?


>
     
     
     >
     
      *_DEBUG_* stuff-  Lots of defines to make lots of noise debugging various
     
     >
     
      things.  I think DEBUG is on by default, but the various other ones are not.
     
     >
     
      Perhaps we should have an levExtremeDebug and just nuke all the ifdefs.  Or we
     
     >
     
      could assume that the bugs are worked out of these, and nuke them..
     
     
I am indifferent about this - only partially understand it. =/


>
     
     
     >
     
      PLUGINS - I think this define should go.  If it compiles without Python libs,
     
     >
     
      it should just be the default.
     
     
I am indifferent about this - only partially understand it. =/


>
     
      LOSSY_ALCHEMY- Looks like this modifies the alchemy spell. It's off by
     
     >
     
      default.. I don't think gold nuggets are a significant form of abuse.  I say
     
     >
     
      vaporize it.
     
     
So, to make sure..

Right now, players are able to cast alchemy over a pile of goblin parts
and get gold nuggets.  Will this feature continue or stop?

Since this is a rather important topic, can get feedback or decision on
this by 21-Nov-2002 ?


- Rick Tanner
     
     leaf at real-time.com