[CF-Devel] New comunication commands. 'me and 'set_reply

[crossfire-devel-admin at archives.real-time.com]

>
     
      diff -u -r1.15 c_chat.c
     
     >
     
      --- server/c_chat.c	28 Jul 2003 05:19:35 -0000	1.15
     
     >
     
      +++ server/c_chat.c	16 Sep 2003 03:31:33 -0000
     
     >
     
      @@ -162,8 +162,62 @@
     
     >
     
           return 1;
     
     >
     
       }
     
     
  <snip>

>
     
      +    else if (!strncmp(params,"-v",2)) {
     
     >
     
      +        /* View the reply_to value if it exists */
     
     >
     
      +        if (op->contr->reply_to==NULL) {
     
     
  That above if will never reveal true.  That is because reply_to will always 
point to some string data.

  What you probably really want is 'if (op->contr->reply_to[0] == '\0') {' ...
Check that the actual string is actually a null string.

  Otherwise, the patch seems OK.  But I think at some level, I think improving 
the handling of this on the client would be a me relevant (a better chat interface).

  At some level, I don't want to re-invent irc within crossfire.



_______________________________________________
crossfire-devel mailing list
     
     crossfire-devel at lists.real-time.com
     
     
     https://mailman.real-time.com/mailman/listinfo/crossfire-devel