[CF-Devel] Missing archetypes used by python plugin

[crossfire-devel at archives.real-time.com]

Todd Mitchell wrote:
>
     
      Andreas Kirschbaum wrote:
     
     >
     
     
     >>>
     
      From my point of view only the functions CheckInvisibleObject() and
     
     >>
     
     
     >>
     
      CreateInvisibleObject() are useful (and currently working). The
     
     >>
     
      remaining functions should be removed. Is this "fix" of the plugin code
     
     >>
     
      acceptable?
     
     >>
     
     
     >>
     
      _______________________________________________
     
     >>
     
     
     >>
     
     
     >
     
      I believe so.  I have only ever used the invisible object function and 
     
     >
     
      the others I have not as I assumed they were legacy code. I don't know 
     
     >
     
      if there is an issue where it is different with inserting these 
     
     >
     
      invisible inventory objects as opposed to visible inventory objects.  
     
     
  Shouldn't really be any difference (aside from the obvious, like visible 
objects will be seen by th player).  But I believe even invisible objects can 
merge, it is just that most every invisible object has 'nrof 0' so it won't merge.

>
     
      Really you should just create the arch by name and it will have 
     
     >
     
      visibility as a property or not - there should be no diffrnece in 
     
     >
     
      creating a marker or spell object from creating a shield or glove 
     
     >
     
      object.  However, I haven't tried this and if there is  a difference 
     
     >
     
      then the way this should work is to be able to insert these types of 
     
     >
     
      archetypes by passing their name from a single function instead of 
     
     >
     
      having a function for each type.  Perhaps adding an optional archetype 
     
     >
     
      name field which defaults to 'force' to the InvisibleObject() functions.
     
     
  Creation of objects is all the same.  The only real difference is in the 
defaults - if you are making a glove, starting from the glove archetype is 
easier, becaus it will ahve the type/subtype/body_info/etc all set up as needed, 
where if you do it from an empty object, more work needs to be done.

  In the case of the player_force objects, it sounds like the only special 
feature they had was the name, so not much extra work there.

  I'm not sure if perhaps their removal had something to do with the older 
character creation system (back when there was just a class/race feature as one 
selection, not like now where you can select both class and race as two distinct 
features)

>
     
     
     >
     
      Another big thing along the same lines would be to clean up the spell 
     
     >
     
      and skill stuff...  I don't know how the spell and skill wrappers can be 
     
     >
     
      loaded into the plugin any longer now that they are dynamically loaded 
     
     >
     
      from the arches, but this is a lot of legacy code in the plugin.
     
     
  I don't know how out of date the skill stuff is.

  The spell stuff is, for lack of better term, broken, since the the new spell 
code is completely different.  OTOH, since spells are now objects, one can 
insert/remove/change them through normal object manipulation functions - before, 
they were basically hard coded values stored in an array in the player 
structure, so removing and adding them required special functions.


_______________________________________________
crossfire-devel mailing list
     
     crossfire-devel at lists.real-time.com
     
     
     https://mailman.real-time.com/mailman/listinfo/crossfire-devel