[CF-Devel] Some warning cleaning

[crossfire-devel at archives.real-time.com]

Hello.

I committed a few patches to clean some compilation warnings (mainly type 
matching, for map coordinates & stats).
There are some left, because stuff like 'sint16 + sint16' yields (at least under 
Windows) an int, thus integral size mismatch in function call if it expects a 
sint16 (case of most map coordinates-related functions). But fixing those ones 
would require explicit casts around all (sint16+sint16), which sounds pretty ugly...

Most of the other warnings I have left are signed/unsigned mismatch. I'd want to 
fix'em, but this is potentially easy to break things with those fixes.
What do you think? Is it worth trying to fix signed/unsigned mismatches, or do 
we just let'em, hoping they won't be a bother later?


Also, in common/porting.c, is there a compelling reason why strdup_local(), 
strncasecmp(), strcasecmp() and strcasestr_local() take char* and not const 
char* as arguments? Since strings are used only for comparison, and not changed.

Nicolas 'Ryo'

_______________________________________________
crossfire-devel mailing list
     
     crossfire-devel at lists.real-time.com
     
     
     https://mailman.real-time.com/mailman/listinfo/crossfire-devel