[crossfire] Re: [Crossfire-cvs] CVS commit: arch/food

[Andreas Kirschbaum]

     crossfire-cvs-admin at lists.sourceforge.net
     
      wrote:
>
     
      Module Name:	arch
     
     >
     
      Committed By:	ryo_saeba
     
     >
     
      Date:		Sun Jul 10 09:36:32 UTC 2005
     
     [...]
>
     
      Index: arch/food/booze.arc
     
     >
     
      diff -c arch/food/booze.arc:1.2 arch/food/booze.arc:1.3
     
     >
     
      *** arch/food/booze.arc:1.2	Thu May 30 20:52:55 2002
     
     >
     
      --- arch/food/booze.arc	Sun Jul 10 02:36:31 2005
     
     >
     
      ***************
     
     >
     
      *** 8,13 ****
     
     >
     
      --- 8,14 ----
     
     >
     
        value 5
     
     >
     
        weight 6500
     
     >
     
        editable 2048
     
     >
     
      + randomitems emptyboozebottle
     
     >
     
        identified 1
     
     >
     
        name_pl boozes
     
     >
     
        client_type 611
     
     
This patch seems to create quite a few problems. Applied boozes now
create an empty bottle (as intended), but it causes other problems with
boozes now:

 - picking up one booze does work, but picking up another booze leaves
   an empty bottle on the ground

 - throwing a booze, an empty bottle drops on the ground below you

 - after throwing a stack of two boozes, you find three boozes on the
   ground: a stack of two boozes, and a single one; they merge back into
   two boozes if you pick them up

 - destroying a booze with a spell creates an empty bottle

 - sometimes "empty bottles of Woe" or "empty bottle of Ilrya" are
   created

 - formerly thrown bottles sometimes disappear after the map got swapped
   out

You could consider these "problems" as just strange behavior, but atop
of that, the server tends to crash now. Unfortunately, I was not able to
reliable reproduce these crashes. But all crashes I got occurred only if
the line "randomitems emptyboozebottle" was present in the booze
archetype.

My server log included the following messages:

    Trying to insert in null-map!
    arch boozebottle_empty
    name empty bottle
    name_pl empty bottles
    title of Ilrya
    skill one handed weapons
    face boozebottle_empty.111
    dam 1
    nrof 1
    type 15
    attacktype 1
    material 4
    materialname glass
    value 30
    weight 800
    last_sp 10
    weapontype 8
    client_type 611
    body_arm -1
    end

    fix_generated_item: Unable to generate treasure for booze
    Player 'dm' tried apply the unknown object (1869)
    Player 'dm' tried examine the unknown object (1869)

Furthermore, my server once apparently got into an endless loop and
printed the following messages over and over until I killed it:

    Trying to free freed object.
    arch dungeon_floor
    face dung_floor.111
    x 9
    y 3
    no_pick 1
    is_floor 1
    end