[crossfire] Valgrind results

Andreas Kirschbaum kirschbaum at myrealbox.com
Sat Mar 26 11:36:54 CST 2005


Alex Schultz wrote:

>
     
      From what I can see, the main leak problems are in image.c in the
     
     >
     
      function create_and_rescale_image_from_data.
     
     
I'm currently trying to fix this problem. There are at least two bugs as
far as I can see:

 - The server keeps sending the image information for face 0 over and
   over.

   This seems incorrect to me (both sending it over and over, and
   sending it at all), because the client already preallocates the face
   0 as a black face.

 - The client (that is, all clients) cannot handle "updated" face
   information: the function create_and_rescale_image_from_data() does
   not free the previous contents of pixmaps[] before writing the new
   value.

    
    


More information about the crossfire mailing list