[crossfire] Character names, was Re: Changing connection texts

[Mark Wedel]

Nicolas Weeger wrote:

> 
> 
>>   The problems we run into is that tends not to be done/not clear what
>> 'some time' is.  6 months?  3 years?
> 
> Add near your checking code:
> if (current_date() >= "may 2010") {
> 	LOG(llevError, "obsolete code detected!\n");
> 	exit(5);
> }
> 
> Issue solved :)

  I wonder if you could do that if #ifdef's :)


> 
> 
>>   But there are really 2 cases of legacy supported needed - legacy support
>> for login without the account support (for old clients), and player file
>> naming.
> 
> No account support shouldn't be too hard to compensate.
> Clients can reply to arbitrary "queries", IIRC - so just emulate accounts 
> through that.

  Yeah, no account support isn't hard, because that basically just uses the code 
that is there instead of the new code.  So very simple, it is just having some 
legacy code sit around.

> 
> 
>>   The second one, as I note above, can be eliminated with some scripts. 
>> The first one probably needs some support - maybe 6 months after we release
>> a client that supports it?
> 
> If it's on the trunk branch, I'd suggest to remove it after some days only. 
> Trunk is supposed to be unstable.

  Fair enough.  I was thinking of going through and cleaning up a bunch of the 
protocol stuff - there are like 20 different setup options.  Some are actual 
choices (mapsize, do you want lighting, etc).  But a fair a number are related 
to protocol versions (I support these protocol commands - use them if possible)

> 
> 
> Or, another option I'd prefer, we forget 1.x, declare current trunk 2.0, and 
> then start fixing stuff.

  That may not be a bad idea.  It's been a _long_ time since any official 
release.  I don't think 2.0 is ready right now for a release, but the amount of 
cleanup/fixes probably isn't huge.